Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix & Add: Japanese Translation #2209

Closed
wants to merge 0 commits into from

Conversation

Hima-Zinn
Copy link
Contributor

@Hima-Zinn Hima-Zinn commented Dec 14, 2023

(English Translated by DeepL)
Dear Bluesky developers

Hello, my name is Hima (Hima-Zinn) and I'm a frequent user of Bluesky.
Congratulations on the release of the Japanese version.

I'm sending you a request for some corrections & additions.
Please note that I am not an expert in Japanese, just a university student of computer science, so I hope that the translation will continue to be updated by various Japanese speakers (especially those living in Japan) to make it better.

There are also a few places where I have not been able to fully translate, and I would be happy to add translations if you let me know how they are done.

Please feel free to contact me if you have any questions.
Thank you very much.
Hima

(Japanese (Original))
Blueskyの開発者のみなさま

こんにちは。Blueskyをよく利用しているHima(Hima-Zinn)と申します。
この度は日本語版のリリースおめでとうございます。

いくつか修正&加筆を行ったため、リクエストを送信します。
なお、私は日本語の専門家ではなく、単なるコンピュータサイエンスを学ぶ大学生のため、いろいろな日本話者(特に日本在住の方)によってよりよい翻訳に更新され続けることを願っております。

また、いくつか翻訳しきれていない場所がありますが、その箇所はどのようになっているかお知らせいただければ翻訳を追加したいと考えております。

なにかありましたらお気軽にご連絡ください。
よろしくお願いいたします。
Hima

@nostr-bluesky
Copy link

We are ready for a more coordinated localization.

Copy link
Contributor

@tkusano tkusano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed some changes.

src/locale/locales/ja/messages.po Outdated Show resolved Hide resolved
src/locale/locales/ja/messages.po Outdated Show resolved Hide resolved
src/locale/locales/ja/messages.po Outdated Show resolved Hide resolved
src/locale/locales/ja/messages.po Outdated Show resolved Hide resolved
src/locale/locales/ja/messages.po Outdated Show resolved Hide resolved
src/locale/locales/ja/messages.po Outdated Show resolved Hide resolved
src/locale/locales/ja/messages.po Outdated Show resolved Hide resolved
src/locale/locales/ja/messages.po Outdated Show resolved Hide resolved
src/locale/locales/ja/messages.po Outdated Show resolved Hide resolved
src/locale/locales/ja/messages.po Outdated Show resolved Hide resolved
@Hima-Zinn
Copy link
Contributor Author

指摘箇所を反映してきます。

@Hima-Zinn
Copy link
Contributor Author

@tkusano
Thank you for your cooperation.
I have corrected the problem, please review it again.

@Hima-Zinn
Copy link
Contributor Author

Hima-Zinn commented Dec 14, 2023

アップデート:「~する」と文末に来るものを削除。
(例:Block account 「アカウントをブロックする」→「アカウントをブロック」)
理由:文字数増加によるGUIの乱れを防ぐため。

@tkusano
Copy link
Contributor

tkusano commented Dec 14, 2023

updated-Hima-Zinn.ja.po.txt

Updated latest Hima-Zinn's suggested message.po.

@Hima-Zinn
Copy link
Contributor Author

アップデート:「新しい投稿」を「投稿」に変更
理由:日本語を使用しているユーザーから「新しい投稿」にしたことによるGUIの崩れを指摘している投稿があったため。

@tkusano
Copy link
Contributor

tkusano commented Dec 14, 2023

messages.po.diff

May failed to upload updated messages.po.
See above gist to access diff.

@Hima-Zinn
Copy link
Contributor Author

Hima-Zinn commented Dec 14, 2023

翻訳時間はこれからもまだ修正があると思われるため、管理者の方の確認をもらうまでまだ修正していません。

Note: The translation time has not yet been modified until I have confirmation from the administrator, as I expect there will still be more modifications in the future.

Copy link
Contributor

@tkusano tkusano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reviewed

Copy link
Contributor

@dolciss dolciss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have commented on the points of concern, please confirm.

気になった点にコメントさせていただきましたので確認ください。

src/locale/locales/ja/messages.po Outdated Show resolved Hide resolved
src/locale/locales/ja/messages.po Outdated Show resolved Hide resolved
src/locale/locales/ja/messages.po Outdated Show resolved Hide resolved
src/locale/locales/ja/messages.po Outdated Show resolved Hide resolved
@Hima-Zinn
Copy link
Contributor Author

@dolciss Thank you for your cooperation. I have integrated all your suggestions.

@tkusano
Copy link
Contributor

tkusano commented Dec 14, 2023

Translated 1 untranslated messages.
messages.po.diff

@ansh
Copy link
Contributor

ansh commented Dec 14, 2023

@Hima-Zinn @tkusano @dolciss Does this PR have the latest and correct version of messages.po for the Japanese translations with all the changes you all made?

@dolciss
Copy link
Contributor

dolciss commented Dec 14, 2023

I’m all right 👍

@tkusano
Copy link
Contributor

tkusano commented Dec 14, 2023

almost all okay except 1 untranslated message (see my latest comment).

@Hima-Zinn
Copy link
Contributor Author

@ansh
We are ready to update the latest Japanese version.
One thing I would like to ask you to check is that the information entry in the header of the updated file is correct like this.
If there are any errors, please feel free to let me know.

@Hima-Zinn
Copy link
Contributor Author

little fix
再投稿→リポスト
引用投稿→引用
These changes were made because other Japanese users submitted that it would be easier to understand if we changed to this notation.

Copy link
Contributor

@oboenikui oboenikui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

一点コメントさせていただきました。ご確認いただけますと幸いです。

src/locale/locales/ja/messages.po Outdated Show resolved Hide resolved
@Hima-Zinn
Copy link
Contributor Author

Fix: Corrected some wording.

@Hima-Zinn
Copy link
Contributor Author

Hima-Zinn commented Dec 15, 2023

Dear ansh
(or maintainers of this repository)

I would appreciate your checking and merging if possible, as I am probably sleeping during the time you are active.
This kind of activity needs to continue, so I think we need to have various people correct this in the future, not just this PR.

@mimonelu
Copy link

横からすみませんが、「新しい投稿」に関しては文字列のトリムではなく、無意味に設定されたボタンの横幅( width: 140px; )を取り除き、リキッドデザインに変更する方が好ましいと思われます。多言語化を進めるうちに否が応でも修正されるとは思いますが…

@Hima-Zinn
Copy link
Contributor Author

Hima-Zinn commented Dec 15, 2023

横からすみませんが、「新しい投稿」に関しては文字列のトリムではなく、無意味に設定されたボタンの横幅( width: 140px; )を取り除き、リキッドデザインに変更する方が好ましいと思われます。多言語化を進めるうちに否が応でも修正されるとは思いますが…

@ansh How should we address this issue?
If you could address this issue immediately, I would try to unify the Japanese translation to "新しい投稿".
image
If possible, I would like to make the new post as "新しい投稿" and I would like to see the Japanese in this image without line breaks.

@Hima-Zinn
Copy link
Contributor Author

@ansh @tkusano @dolciss @mimonelu
For now, I will return "新しい投稿" to its original state where it was "投稿" due to the GUI.
I hope this will be resolved as soon as possible.

@haileyok haileyok mentioned this pull request Dec 15, 2023
@tkusano
Copy link
Contributor

tkusano commented Dec 15, 2023

When applied below patch to src/view/shell/desktop/LeftNav.tsx b/src/view/shell/desktop/LeftNav.tsx, "New Post" button in LeftNav is displayed correctly.

diff --git a/src/view/shell/desktop/LeftNav.tsx b/src/view/shell/desktop/LeftNav.tsx
index 5d1c2a20..e1e1b98d 100644
--- a/src/view/shell/desktop/LeftNav.tsx
+++ b/src/view/shell/desktop/LeftNav.tsx
@@ -515,7 +515,6 @@ const styles = StyleSheet.create({
     flexDirection: 'row',
     alignItems: 'center',
     justifyContent: 'center',
-    width: 140,
     borderRadius: 24,
     paddingTop: 10,
     paddingBottom: 12, // visually aligns the text vertically inside the button
k

image

@tkusano
Copy link
Contributor

tkusano commented Dec 15, 2023

and with this patch to src/view/shell/desktop/LeftNav.tsx b/src/view/shell/desktop/LeftNav.tsx, "Profile" menu item is localized correctly.

--- a/src/view/shell/desktop/LeftNav.tsx
+++ b/src/view/shell/desktop/LeftNav.tsx
@@ -409,7 +409,7 @@ export function DesktopLeftNav() {
                 style={pal.text}
               />
             }
-            label="Profile"
+            label={_(msg`Profile`)}
           />
           <NavItem
             href="/settings"

image

@Hima-Zinn
Copy link
Contributor Author

Hima-Zinn commented Dec 16, 2023

#2219 (comment)
I've created a new PR for new issue that doesn't display correctly.

Copy link
Contributor

@noritada noritada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

大量の翻訳やチェック、お疲れ様です。
まだ一部しか見ることができていませんが、気になったところをいくつかお送りします。
よろしくお願いいたします。

src/locale/locales/ja/messages.po Outdated Show resolved Hide resolved
src/locale/locales/ja/messages.po Outdated Show resolved Hide resolved
@Hima-Zinn
Copy link
Contributor Author

@noritada Thank you for your cooperation.

@Hima-Zinn
Copy link
Contributor Author

@ansh By the way, the conflicts seem to have occurred because of the upgraded version of the original file.
How should we deal with this?
It seems like it would be difficult to go through the differences and write down every single thing that was changed or added by the upgrade.

@Hima-Zinn
Copy link
Contributor Author

Hima-Zinn commented Dec 18, 2023

I have tried to reflect it manually for now, but the conflict does not seem to be resolved.
Perhaps the content of this file (./ja/messages.po) is able to keep up with the latest version, but conflicts with the files around it.

The following sites were used for comparison: https://difff.jp/47ett.html

@Hima-Zinn
Copy link
Contributor Author

In order to be able to merge automatically, the case has been moved to the following, as it is necessary to be active in a branch with new information.
#2226

@ansh
Copy link
Contributor

ansh commented Dec 18, 2023

Thank you @Hima-Zinn

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants