-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix & Add: Japanese Translation #2209
Conversation
We are ready for a more coordinated localization. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed some changes.
指摘箇所を反映してきます。 |
@tkusano |
アップデート:「~する」と文末に来るものを削除。 |
Updated latest Hima-Zinn's suggested message.po. |
アップデート:「新しい投稿」を「投稿」に変更 |
May failed to upload updated messages.po. |
翻訳時間はこれからもまだ修正があると思われるため、管理者の方の確認をもらうまでまだ修正していません。 Note: The translation time has not yet been modified until I have confirmation from the administrator, as I expect there will still be more modifications in the future. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
reviewed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have commented on the points of concern, please confirm.
気になった点にコメントさせていただきましたので確認ください。
@dolciss Thank you for your cooperation. I have integrated all your suggestions. |
Translated 1 untranslated messages. |
@Hima-Zinn @tkusano @dolciss Does this PR have the latest and correct version of messages.po for the Japanese translations with all the changes you all made? |
I’m all right 👍 |
almost all okay except 1 untranslated message (see my latest comment). |
@ansh |
little fix |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
一点コメントさせていただきました。ご確認いただけますと幸いです。
Fix: Corrected some wording. |
Dear ansh I would appreciate your checking and merging if possible, as I am probably sleeping during the time you are active. |
横からすみませんが、「新しい投稿」に関しては文字列のトリムではなく、無意味に設定されたボタンの横幅( |
@ansh How should we address this issue? |
When applied below patch to diff --git a/src/view/shell/desktop/LeftNav.tsx b/src/view/shell/desktop/LeftNav.tsx
index 5d1c2a20..e1e1b98d 100644
--- a/src/view/shell/desktop/LeftNav.tsx
+++ b/src/view/shell/desktop/LeftNav.tsx
@@ -515,7 +515,6 @@ const styles = StyleSheet.create({
flexDirection: 'row',
alignItems: 'center',
justifyContent: 'center',
- width: 140,
borderRadius: 24,
paddingTop: 10,
paddingBottom: 12, // visually aligns the text vertically inside the button
k |
and with this patch to --- a/src/view/shell/desktop/LeftNav.tsx
+++ b/src/view/shell/desktop/LeftNav.tsx
@@ -409,7 +409,7 @@ export function DesktopLeftNav() {
style={pal.text}
/>
}
- label="Profile"
+ label={_(msg`Profile`)}
/>
<NavItem
href="/settings" |
#2219 (comment) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
大量の翻訳やチェック、お疲れ様です。
まだ一部しか見ることができていませんが、気になったところをいくつかお送りします。
よろしくお願いいたします。
@noritada Thank you for your cooperation. |
@ansh By the way, the conflicts seem to have occurred because of the upgraded version of the original file. |
I have tried to reflect it manually for now, but the conflict does not seem to be resolved. The following sites were used for comparison: https://difff.jp/47ett.html |
In order to be able to merge automatically, the case has been moved to the following, as it is necessary to be active in a branch with new information. |
Thank you @Hima-Zinn |
(English Translated by DeepL)
Dear Bluesky developers
Hello, my name is Hima (Hima-Zinn) and I'm a frequent user of Bluesky.
Congratulations on the release of the Japanese version.
I'm sending you a request for some corrections & additions.
Please note that I am not an expert in Japanese, just a university student of computer science, so I hope that the translation will continue to be updated by various Japanese speakers (especially those living in Japan) to make it better.
There are also a few places where I have not been able to fully translate, and I would be happy to add translations if you let me know how they are done.
Please feel free to contact me if you have any questions.
Thank you very much.
Hima
(Japanese (Original))
Blueskyの開発者のみなさま
こんにちは。Blueskyをよく利用しているHima(Hima-Zinn)と申します。
この度は日本語版のリリースおめでとうございます。
いくつか修正&加筆を行ったため、リクエストを送信します。
なお、私は日本語の専門家ではなく、単なるコンピュータサイエンスを学ぶ大学生のため、いろいろな日本話者(特に日本在住の方)によってよりよい翻訳に更新され続けることを願っております。
また、いくつか翻訳しきれていない場所がありますが、その箇所はどのようになっているかお知らせいただければ翻訳を追加したいと考えております。
なにかありましたらお気軽にご連絡ください。
よろしくお願いいたします。
Hima