Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update the catalan localization with the newly added lines #2644

Merged
merged 4 commits into from
Feb 5, 2024
Merged

Update the catalan localization with the newly added lines #2644

merged 4 commits into from
Feb 5, 2024

Conversation

ivanbea
Copy link
Contributor

@ivanbea ivanbea commented Jan 26, 2024

Update the catalan localization with the newly added lines

@ivanbea
Copy link
Contributor Author

ivanbea commented Jan 26, 2024

Added new localizations, you can check it @jordimas @darccio @ferranrego @MiquelAdell @mvdan @johnnydement @Mejans

@ivanbea
Update messages.po
a48f4fc 
Apply @surfdude26 and @jordimas corrections
@pfrazee
Copy link
Collaborator

pfrazee commented Jan 26, 2024

Good to go?

@pfrazee pfrazee added the intl Internationalization label Jan 26, 2024
@ivanbea
Copy link
Contributor Author

ivanbea commented Jan 26, 2024

Yes, I corrected the errors found by @surfdude29 and @jordimas and it looks ready to go now

@MiquelAdell
Copy link

Were the lines not previously appearing on the po file? They were introduced in the last update or something like that?
If that is the case the file looks fine to me.

@ivanbea
Copy link
Contributor Author

ivanbea commented Jan 29, 2024

Yes, they added more lines for localization, and I suspect that this will not be the last update

darccio
darccio reviewed Feb 4, 2024
View reviewed changes
Copy link
Contributor

@darccio darccio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pfrazee
Copy link
Collaborator

pfrazee commented Feb 5, 2024

Awesome, thanks everyone! Merged

@pfrazee pfrazee merged commit 7caf927 into bluesky-social:main Feb 5, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@surfdude29 surfdude29 surfdude29 left review comments

@jordimas jordimas jordimas left review comments

@darccio darccio darccio left review comments

Assignees
No one assigned
Labels
intl Internationalization
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@ivanbea @pfrazee @MiquelAdell @darccio @jordimas @surfdude29