[iPad support] Custom tab navigator for native tablet, with side nav #3465
+405
−162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mozzius
force-pushed
the
samuel/ipad-fixes-2
branch
from
842f0c9 to
b020554
Compare
|
Open
mozzius
force-pushed
the
samuel/ipad-fixes-2
branch
2 times, most recently
from
6a7ebff to
e81bb86
Compare
mozzius
force-pushed
the
samuel/ipad-fixes-2
branch
from
e81bb86 to
da1b956
Compare
|
Your Render PR Server URL is https://social-app-pr-3465.onrender.com. Follow its progress at https://dashboard.render.com/web/srv-cpjmqs8l6cac73cpv4vg. |
mozzius
force-pushed
the
samuel/ipad-fixes-2
branch
2 times, most recently
from
30915b2 to
7971a3e
Compare
…3385) * fix fab position * show left nav * custom tab navigator for tablets * re-disable right nav on tablet * fix unread count not being rounded * use mobile subpage header on native tablet * fix feed being hidden under header * rename misleading variable name * remove drawer on native tablet, as on web tablet * fix prompt styles on tablet * import isWeb (ts-ignore 😡) * disable emoji picker on tablet * prettier format
mozzius
force-pushed
the
samuel/ipad-fixes-2
branch
from
7971a3e to
8fcd649
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stacked on #1569
This PR create a custom navigatior for the native tablet layout, mimicking the web tablet layout. However, the web navigator is in a flat structure, whereas on native it needs to maintain a stack navigator for each tab.
Test plan