-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Video] Add uploaded video to post #4884
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Your Render PR Server URL is https://social-app-pr-4884.onrender.com. Follow its progress at https://dashboard.render.com/web/srv-cqp7jig8fa8c73d8a9j0. |
haileyok
reviewed
Aug 7, 2024
haileyok
reviewed
Aug 7, 2024
haileyok
approved these changes
Aug 7, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some questions but looks good.
mozzius
force-pushed
the
samuel/video-lex
branch
2 times, most recently
from
August 13, 2024 15:12
af845fc
to
d55faaa
Compare
mozzius
force-pushed
the
samuel/video-uploads-fr-this-time
branch
from
August 13, 2024 15:16
9c52905
to
98079cb
Compare
|
mozzius
force-pushed
the
samuel/video-lex
branch
3 times, most recently
from
August 23, 2024 21:10
42c4fb4
to
275a02f
Compare
mozzius
force-pushed
the
samuel/video-uploads-fr-this-time
branch
from
August 26, 2024 13:34
1352379
to
3ff95a1
Compare
mozzius
force-pushed
the
samuel/video-lex
branch
from
August 29, 2024 10:16
275a02f
to
b6876d4
Compare
mozzius
force-pushed
the
samuel/video-uploads-fr-this-time
branch
from
August 29, 2024 11:26
3ff95a1
to
b47c6da
Compare
haileyok
reviewed
Aug 29, 2024
haileyok
reviewed
Aug 29, 2024
haileyok
reviewed
Aug 29, 2024
haileyok
reviewed
Aug 29, 2024
mozzius
force-pushed
the
samuel/video-uploads-fr-this-time
branch
from
August 29, 2024 15:16
31b4218
to
0d4d418
Compare
estrattonbailey
added a commit
that referenced
this pull request
Aug 29, 2024
* origin/main: (520 commits) Fix language filtering for feeds (#5026) Enable show_follow_back_label_v2 (#5022) Remove logging of following prefs (#5021) Remove new_user_guided_tour and tour code (#5023) [Video] Remove old env var (#5018) Profile screen performance tweak - Adjust initial num to render based on header height (#5005) [Video] Make compress/upload cancelable (#4996) [Video] Add uploaded video to post (#4884) [Video] Add `timeRemainingChange` event to `player` in `expo-video` (#5013) [Video] Lexicon implementation (#4881) Hide quote counts for quotegated posts (#5011) Ensure captcha verification code gets submitted in signup request (#5010) clean up languages (#5007) [Video] 🫧 Move logic around by platform (#5003) bump 1.91.0 (#5002) add indicator of time remaining (#5000) [Video] add scrubber to the web player (#4943) Release 1.90 prep (#4988) Use moderatePost_wrapped for post embeds (#4981) Update Indonesian translation (#4875) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stacked on #4732 and #4881
Connecting the dots...