Fix alignment of posts in Right-To-Left languages #635
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm having trouble evaluating this PR -- the before & after look similar on the first platform I tested (Web). Can you show me screenshots of the effects of this on all 3 platforms? |
pfrazee
added
the
x:changes-requested
|
When the post is not long enough to fill the whole container width, the dir="auto" attribute has no effect. Before: After: Unfortunately, I can't get the project to build for iOS/Android. |
|
Doesn't work for me either. In some of the components the text element is wrapped by a flex parent with flex-start position. |
|
LGTM |
|
This solution doesn't seem to work consistently. We're aware of the problem but I'm going to close the PR since it's not the right fix |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.