skip confirmation for closing composer when there's no text entered #680
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benharri
force-pushed
the
skip-confirmation-for-empty-post
branch
2 times, most recently
from
3687f02 to
163c92c
Compare
|
What about if they've attached images? Do we still want to fast exit? |
pfrazee
added
the
x:discussing
|
This is something I noticed while debugging it - there's no prompt even with images attached when you click the normal cancel button. I will poke around and see if I can get that behavior to be consistent for both. |
benharri
force-pushed
the
skip-confirmation-for-empty-post
branch
from
163c92c to
670bc7c
Compare
|
Added the gallery check and moved the check for both esc and the actual cancel button |
benharri
force-pushed
the
skip-confirmation-for-empty-post
branch
2 times, most recently
from
8d9c251 to
8b9b8c1
Compare
pfrazee
added
x:planned
|
Appreciate the updates! Need to test then I'll merge |
benharri
force-pushed
the
skip-confirmation-for-empty-post
branch
6 times, most recently
from
d570aaf to
115f8e1
Compare
benharri
force-pushed
the
skip-confirmation-for-empty-post
branch
2 times, most recently
from
db3baa1 to
b923865
Compare
benharri
force-pushed
the
skip-confirmation-for-empty-post
branch
from
b923865 to
ed35d9f
Compare
- prompt now appears for the cancel button - no prompt when post is empty - appease eslint
benharri
force-pushed
the
skip-confirmation-for-empty-post
branch
from
ed35d9f to
2e082b6
Compare
|
Oh nice, the linter stopped complaining with this rebase. This is good to go as far as I can tell. |
|
Made a couple of adjustments and merged. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.