-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added contextual image to AltImage #694
Conversation
I really appreciate the thought you put into this, but I think there's a simpler option! Rather than collapsing the image, what if we kept it full-sized but then put everything in a scrollview and autofocused the input so that the UI takes us down to it straight away? Then you can easily scroll up to reference your image |
Great advice @pfrazee, it looks a whole lot better now! The entire modal is now contained within a I've pushed this code to this branch and this is what it looks like: Something else I played with is this. The image is still contained within a |
For the second, it might look better if the background behind the submit was semi-opaque. Right now it looks horrible being over the image |
Absolutely agree. As I mentioned I was lazy and it was more of showing off a quick idea I had and not bothering to properly style it. |
Sweet, thanks. When I get some time I'll take this to the finish line |
Thanks again everybody. I ended up tackling this over here #910 Cheers |
Adds a feature that allows users to see the image they are adding alt text to as described in #658
By default the image in the Alt Text modal will be shown fully and then it's height will be collapsed so the user can partially see the image, text box, and keyboard, along with the CTAs.