support i18n #782
Closed
support i18n #782
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
I like where this is headed, but localization is a pretty huge undertaking and we're just super not ready for this right now. We're barely keeping up with the existing task load. |
pfrazee
added
x:putting-this-off
@pfrazee I understand it's huge, I will just leave this PR here in case you want to start working on it. Keep up on other tasks😁 |
|
Closing this in favor of #1822 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolve #734
This draft PR add basic support for i18n and using splash screen and the first step of "create a new account" as demo, you can't change locale manually and only support english now.
To add other language you will need to:
localenaming with language tag (e.g.en-US)enfolder to the folder aboveresources.tsNot fully functional, still need polishing.