This repository has been archived by the owner on Sep 20, 2019. It is now read-only.
TST: Make tests go 7X faster by using module fixtures. #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using function-scoped fixtures gives better isolation between tests. I believe that function-scope isolation is important for testing data *writing* (i.e. suitcase) but taht module-scope isolation is sufficient for reading.
This comment has been minimized.
This comment has been minimized.
danielballan
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Locally, pytest runs all the tests in 103s, down from 773s on
master.Using function-scoped fixtures gives better isolation between tests.
I believe that function-scope isolation is important for testing
data writing (i.e. suitcase) but taht module-scope isolation is
sufficient for reading.
Four tests fail due to a bad interaction related to filling in place.
Those of course need to be fixed before this should be merged.