Skip to content
Browse files

Skip results if testing was incomplete on unload

If a user navigates away from a page on which bandwidth is being tested
(i.e. before the file download probes are finished), the accuracy of
the results vary widely.

Therefore, don't save or report bw results if testing didn't complete
before user navigates off page.

A side-effect of this change is that bw testing will run on subsequent
pages until it finishes (which only requires that a user remain on a
page for 15s, so valid data should come quickly).

(cherry picked from commit 546889f)

Signed-off-by: Philip Tellis <philip@lognormal.com>
  • Loading branch information...
1 parent 54e8316 commit 532774c94acf44ba611c4ade899b359e51a8c580 @EricGoldsmith EricGoldsmith committed with
Showing with 0 additions and 2 deletions.
  1. +0 −2 plugins/bw.js
View
2 plugins/bw.js
@@ -538,8 +538,6 @@ BOOMR.plugins.BW = {
skip: function() {
// this is called on unload, so we should abort the test
- // if it's already started and report results.
- this.abort();
// it's also possible that we didn't start, so sendBeacon never
// gets called. Let's set our complete state and call sendBeacon.

0 comments on commit 532774c

Please sign in to comment.
Something went wrong with that request. Please try again.