Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP
Browse files

Ignore clicks on flash objects

Chrome for Linux using PepperFlash tends to bubble click events between
flash and JavaScript.  This causes problems if the flash object requires
the ability to handle multiple fast clicks and boomerang spends some
time figuring out what the target of the click was.

This patch ignores clicks if they occurred on a flash object.
  • Loading branch information...
commit de1aabd255f7fab10a40eb9d5d80dd064412a656 1 parent 720f652
@bluesmoon authored
Showing with 5 additions and 0 deletions.
  1. +5 −0 boomerang.js
View
5 boomerang.js
@@ -89,6 +89,11 @@ impl = {
if (target.nodeType == 3) // defeat Safari bug
target = target.parentNode;
+ // don't capture clicks on flash objects
+ // because of context slowdowns in PepperFlash
+ if(target && target.nodeName.toUpperCase() === "OBJECT" && target.type === "application/x-shockwave-flash") {
+ return;
+ }
impl.fireEvent("click", target);
},
Please sign in to comment.
Something went wrong with that request. Please try again.