From 33c96ca658fd7a0d358dd714decf465ff17ee043 Mon Sep 17 00:00:00 2001 From: Luiz Augusto von Dentz Date: Wed, 22 Jun 2022 11:09:04 -0700 Subject: [PATCH] client/player: Fixes errors found by scan-build This fixes the following errors: client/player.c:1406:44: warning: Dereference of null pointer [core.NullDereference] reply = endpoint_select_config_reply(msg, p->data.iov_base, ^~~~~~~~~~~~~~~~ client/player.c:1866:2: warning: 3rd function call argument is an uninitialized value [core.CallAndMessage] iov_append(&cfg->caps, data, len); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ --- client/player.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/client/player.c b/client/player.c index 2ba05c43c5..3e9a457ec8 100644 --- a/client/player.c +++ b/client/player.c @@ -1403,6 +1403,12 @@ static DBusMessage *endpoint_select_configuration(DBusConnection *conn, if (!p) NULL; + if (p->data.iov_base) { + reply = g_dbus_create_error(msg, "org.bluez.Error.Rejected", + NULL); + return reply; + } + reply = endpoint_select_config_reply(msg, p->data.iov_base, p->data.iov_len); if (!reply) @@ -1859,7 +1865,7 @@ static void endpoint_config(const char *input, void *user_data) { struct endpoint_config *cfg = user_data; uint8_t *data; - size_t len; + size_t len = 0; data = str2bytearray((char *) input, &len);