Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error loading model: value 'AND' is not legal #6

Closed
agarciadom opened this issue Jun 19, 2021 · 4 comments
Closed

Error loading model: value 'AND' is not legal #6

agarciadom opened this issue Jun 19, 2021 · 4 comments
Labels
bug Something isn't working

Comments

@agarciadom
Copy link
Member

The reference and Epsilon solutions use a statically-generated metamodel which still uses the "and" casing for the operator. Unfortunately, commit b4d4df changed the casing to "AND", and broke both the reference and the Epsilon solution.

Can we either:

  • Regenerate the metamodel and upload a new Maven artefact for it (@npbhoang), or
  • Revert the change in b4d4df (@georghinkel)?
@agarciadom agarciadom added the bug Something isn't working label Jun 19, 2021
@npbhoang
Copy link
Collaborator

Hi @bluezio ,

Yes, I noticed the problem with the "AND".

I believe reverting the change in b4d4df would be the easiest solution.
Also, I don't think this revert will affect the NMF solution of @georghinkel .

@npbhoang
Copy link
Collaborator

I reverted the change in b4d4df.
@georghinkel , I hope it is okay.

I will run all the solutions again to make sure all works fine.

@georghinkel
Copy link
Contributor

I have to investigate why, but NMF currently silently ignores parsing errors and if the casing is not correct, treats the element as equals. That does not make a difference in the scenarios considered.

@npbhoang
Copy link
Collaborator

npbhoang commented Jun 21, 2021

Hi @georghinkel ,

Don't worry, I change the metamodel so that now it uses "AND" as operator for the reference case and Epsilon also.

Sorry, the last time I wasn't paying attention to the weird "and" parsing since all scenarios are passed.
Only today, while playing with more complex OCL expressions, I noticed the parsing errors.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants