Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Impl Tokio traits for Either? #44

Closed
Hirrolot opened this issue Dec 31, 2019 · 2 comments
Closed

Impl Tokio traits for Either? #44

Hirrolot opened this issue Dec 31, 2019 · 2 comments

Comments

@Hirrolot
Copy link

How about implementing Tokio traits for Either? Not there is a third-party crate for it, but it's kinda ecosystem fragmentation, isn't it?
@cuviper
Copy link
Member

cuviper commented Dec 31, 2019

Given the relative size and scope of the crates, and the fact that tokio is still evolving pre-1.0 while either is already 1.5, I think it would be better for tokio to (optionally) depend on this crate and implement its traits for Either.

@Hirrolot
Copy link
Author

I agree with you, however, tokio-rs/tokio#1685 (comment). Anyway, thanks for the reply.

@Hirrolot Hirrolot closed this as completed Jan 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@cuviper @Hirrolot