Skip to content

/petgraph

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compilation for rust nightly #154

Merged
merged 1 commit into from Jun 16, 2017

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@daboross @nikomatsakis @bluss
@daboross
Copy link
Contributor

daboross commented Jun 15, 2017

Very small change to remove ambiguity between Ord::max and IndexType::max in two locations.

I don't directly use this library, only as an indirect dependency, but I hope this is helpful.

Fixes #153.
@daboross
Fix compilation for rust nightly 
Fixes by removing ambiguity between Ord::max and IndexType::max in two locations.
Loading status checks…
8c92aa1
@nikomatsakis

This comment has been minimized.

Sign in to view
Copy link

nikomatsakis commented Jun 15, 2017

(This also affects some older branches, fyi.)

This was referenced Jun 15, 2017

Merged
Merged
@daboross

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

daboross commented Jun 15, 2017

True, thanks for mentioning that. I guess I'll submit another PR towards branch-0.2? I'm not sure there's a branch already existing for 0.3.*.

@daboross daboross referenced this pull request Jun 15, 2017

Closed

Fix compilation for rust nightly for 0.2.* #155

@nikomatsakis

This comment has been minimized.

Sign in to view
Copy link

nikomatsakis commented Jun 16, 2017

@daboross I don't know how @bluss manages it.

@bluss bluss merged commit f0f6e39 into bluss:master Jun 16, 2017
1 check passed

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@bluss

This comment has been minimized.

Sign in to view
Copy link
Owner

bluss commented Jun 16, 2017

Thank you
@bluss

This comment has been minimized.

Sign in to view
Copy link
Owner

bluss commented Jun 16, 2017

Fixed in 0.4.5

@daboross daboross deleted the daboross:fix-2017-06-14-nightly branch Jun 16, 2017

@messense messense referenced this pull request Jul 8, 2017

Closed

Unable to Compile as Crate #157

bluss added a commit that referenced this pull request Jul 27, 2017

@daboross @bluss
Fix compilation for rust nightly (#154) 
Fixes by removing ambiguity between Ord::max and IndexType::max in two locations.
c1a3ba1

illicitonion added a commit to illicitonion/pants that referenced this pull request Sep 1, 2017

@illicitonion
Update petgraph dep to 0.4.5 
rust-lang/rust#42496 means that 0.4.4 no longer
compiles with the most recently released rust toolchain. This was fixed
in bluss/petgraph#154 which is in 0.4.5.
7bb4dc8

@illicitonion illicitonion referenced this pull request Sep 1, 2017

Closed

Update petgraph dep to 0.4.5 #4837

khuey added a commit to khuey/petgraph that referenced this pull request Feb 26, 2018

@daboross @khuey
Fix compilation for rust nightly (bluss#154) 
Fixes by removing ambiguity between Ord::max and IndexType::max in two locations.
2731e2e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.