Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upREADME.md: Clarify policy wrt. contribution and standard library #294
Conversation
bluss
reviewed
Jun 17, 2018
|
|
||
| - Fix a bug or implement a new thing | ||
| - Include tests for your new feature, preferably a quickcheck test | ||
| - Make a Pull Request | ||
|
|
||
| For new features, please first file a PR to `rust-lang/rust <https://github.com/rust-lang/rust/>`_, |
This comment has been minimized.
This comment has been minimized.
bluss
Jun 17, 2018
Owner
Thanks. Can we put some softening here, so that contributors must consider if it can be accepted into std? I think that many things are less general and are only interesting for itertools (even if we mainly like very general iterator functionality too).
This comment has been minimized.
This comment has been minimized.
bluss
Jun 17, 2018
Owner
Along the lines of, must consider but don't have to open a PR vs std if it's reasonable it doesn't belong there.
This comment has been minimized.
This comment has been minimized.
Centril
Jun 17, 2018
Author
Contributor
Perhaps something like "For new features, please first consider filing a PR to <link>, adding your new feature to the Iterator trait of the standard library, if you believe it is reasonable."
(added parts italicized)
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
Nuanced policy per discussion :) |
This comment has been minimized.
This comment has been minimized.
|
Thanks! |
Centril commentedJun 17, 2018
See text in PR ;)
Basically we want to avoid
.flatten()debacles and similar in the future.