Skip to content

Brandon Wallace
bman654

bman654 deleted branch fix-windows-test at bman654/react-redux-starter-kit
@bman654
Fix test runner on Windows
1 commit with 1 addition and 1 deletion
@bman654

yeah I'll do that. We can let Travis test it really works for Linux.

@bman654

ah yeah I can run the original version on Windows if I use Git Bash. But anyway, this line seems to work for both Command Prompt and Git Bash: test…

@bman654

yeah I changed it to test: /sinon\\pkg\\sinon\.js/, and everything works. PhantomJS 2.1.1 (Windows 8 0.0.0): Executed 27 of 27 SUCCESS (1.017 secs …

@bman654

I wonder if this line fails on windows due to path separators? test: /sinon\/pkg\/sinon\.js/,

@bman654

yeah it works if I go to just before that commit (though the app itself doesn't due to an error in the browser JS console): PhantomJS 2.1.1 (Window…

@bman654

I'm gonna go out on a limb and blame it on 3dd4d04. I'll rollback to just before that commit and give it a go.

@bman654

Ok I just repro'd in a fresh directory with absolutely no changes. D:\Documents\t>node -v v5.6.0 D:\Documents\t>npm -v 3.6.0 D:\Documents\t>git clo…

@bman654

I did add a gitattributes file that forces Linux line endings. I'll try a fresh clone without that to see if it makes a difference. Brandon On Fe…

@bman654

Yes with a fresh install of the latest nose 5. Brandon On Feb 9, 2016, at 6:33 PM, David Zukowski notifications@github.com wrote: Is this from a …

@bman654
npm run test fails with errors related to sinon
@bman654

Yeah that looks better. Thanks. I don't have a problem with the way react-redux provides access to the store via a wrapper component. I mean there'…

bman654 commented on pull request jlongster/redux-simple-router#109
@bman654

Actually my idea is to use history library, but just as a history enhancer. But anyway I just realized what you meant. User could click browser bac…

bman654 commented on pull request jlongster/redux-simple-router#109
@bman654

Router.Link just calls pushState on the history object that was given to the router and so never directly modifies the URL. I don't understand what…

bman654 commented on pull request jlongster/redux-simple-router#109
@bman654

I guess what my proposal really is: a ReduxHistory object that you can use with React-Router to make it redux-aware.

bman654 commented on pull request jlongster/redux-simple-router#109
@bman654

I'm referring to your first use case. What is actually happening in #108 is the user is clicking on a ReactRouter.Link element, which then calls hi…

bman654 commented on pull request jlongster/redux-simple-router#109
@bman654

Isn't the whole problem that Router is listening to the history object and updating its internal state (which triggers a re-render) and redux-simpl…

bman654 commented on issue auth0/auth0.js#116
@bman654

:+1:

@bman654
Does this work with server-side rendering?
@bman654
@bman654
bman654 commented on pull request react-bootstrap/react-bootstrap#1099
@bman654

Would have been nice to see this mentioned in the ChangeLog...

Something went wrong with that request. Please try again.