Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

fixed silence flag not being obeyed by routine for uninstalling old version #118

Open
wants to merge 1 commit into from

2 participants

@Jofagi

fixes #116

@bmatzelle
Owner

Looks good. I'll review.

@Jofagi

Any progress on the review so far?

@bmatzelle
Owner

It looks good. I'll be merging it along with some other enhancements when I have some free time.

@Jofagi

Excellent; thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Feb 25, 2014
  1. @Jofagi
This page is out of date. Refresh to see the latest.
Showing with 6 additions and 1 deletion.
  1. +6 −1 setup/Gow.nsi
View
7 setup/Gow.nsi
@@ -171,12 +171,17 @@ Function RemoveOldInstallation
MessageBox MB_OKCANCEL \
"${PRODUCT} is already installed. $\n$\nClick OK to remove the \
previous version or Cancel to cancel this upgrade." \
+ /SD IDOK \
IDOK uninstall
Abort
uninstall:
; Do not copy the uninstaller to a temp file
- ExecWait '$R0 _?=$INSTDIR'
+
+ IfSilent +1 +2
+ StrCpy $R1 "/S" ; Don't break silence when removing old version
+
+ ExecWait '$R0 _?=$INSTDIR $R1'
IfErrors 0 EndFunction
; TODO: Perform error checking here
Something went wrong with that request. Please try again.