fixed unit copy with mongoengine; added cli commands to copy drpm and metafile #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -39,6 +39,8 @@ def initialize(context): | |||
| copy_section.add_command(copy_commands.PackageEnvironmentCopyCommand(context)) | |||
| copy_section.add_command(copy_commands.AllCopyCommand(context)) | |||
| copy_section.add_command(copy_commands.SrpmCopyCommand(context)) | |||
| copy_section.add_command(copy_commands.YumRepoMetadataFileCommand(context)) | |||
| copy_section.add_command(copy_commands.DrpmCopyCommand(context)) | |||
There was a problem hiding this comment.
It turns out this command already existed but just hadn't been added to the structure!
| @@ -102,12 +104,10 @@ def get_rpms_to_copy_by_key(rpm_search_dicts, import_conduit): | |||
| # ignore checksum from updateinfo.xml | |||
| key['checksum'] = None | |||
There was a problem hiding this comment.
What about changing these to be:
del key['checksum']
del key['checksumtype']
If that change works I think it would be better.
There was a problem hiding this comment.
namedtuples don't have default arguments, so you have to supply a value for every parameter. So unfortunately this wouldn't work.
bmbouter
added a commit
that referenced
this pull request
Dec 14, 2015
fixed unit copy with mongoengine; added cli commands to copy drpm and metafile
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.