Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Multiple doctypes #119

Closed
vslinko opened this Issue Jan 8, 2013 · 7 comments

Comments

Projects
None yet
2 participants

vslinko commented Jan 8, 2013

XHTML1.1 document must contain two doctypes from predefined: xml and 1.1.
But that code doesn't work:

doctype xml
doctype 1.1
html(xmlns="http://www.w3.org/1999/xhtml")

What better: add PR where 1.1 doctype contains xml or discuss about allow multiply doctypes in one blade document?

vslinko commented Jan 8, 2013

Temporary solution:

blade.Compiler.doctypes['xhtml'] = blade.Compiler.doctypes['xml'] + blade.Compiler.doctypes['1.1'];
Owner

bminer commented Jan 8, 2013

I think the best solution is to allow multiple doctype definitions at the beginning of the template. I've never really worried about this since some browsers choke on the XML schema declaration. So, I typically just put doctype 1.1 at the beginning of the file. Thoughts?

vslinko commented Jan 8, 2013

Agree with multiple doctype definitions.

@bminer bminer was assigned Jan 8, 2013

Owner

bminer commented Jan 8, 2013

@vslinko - This will be added in the next week or so... before the Blade 3.0 stable release. Will that work, or do you need this feature sooner?

vslinko commented Jan 8, 2013

No I use temporary fix. Thank you.

@bminer bminer closed this in 63ac28d Jan 10, 2013

Owner

bminer commented Jan 10, 2013

This will be included in the next version push (probably 3.0.0beta6 or 3.0.0rc1)

vslinko commented Jan 10, 2013

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment