Deal correctly with paths that contain spaces

bmizerany · Apr 11, 2008 · 53c6609 · 53c6609
1 parent 307f93c
commit 53c6609
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 1 deletion.
diff --git a/lib/sinatra.rb b/lib/sinatra.rb
@@ -145,7 +145,7 @@ class Event
     attr_reader :path, :block, :param_keys, :pattern, :options
 
     def initialize(path, options = {}, &b)
-      @path = path
+      @path = URI.encode(path)
       @block = b
       @param_keys = []
       @options = options

diff --git a/test/application_test.rb b/test/application_test.rb
@@ -1,5 +1,7 @@
 require File.dirname(__FILE__) + '/helper'
 
+require 'uri'
+
 class TesterWithEach
   def each
     yield 'foo'
@@ -155,6 +157,19 @@ def foo
 
   end
 
+  specify "can deal with spaces in paths" do
+
+    path = '/path with spaces'
+
+    get path do
+      "Look ma, a path with spaces!"
+    end
+
+    get_it URI.encode(path)
+
+    body.should.equal "Look ma, a path with spaces!"
+  end
+
 end