Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Columns no longer break properly #62

Closed
erleichdaarchiving opened this issue Jan 18, 2019 · 11 comments
Closed

Columns no longer break properly #62

erleichdaarchiving opened this issue Jan 18, 2019 · 11 comments
Assignees
Labels

Comments

@erleichdaarchiving
Copy link

In the original version (1.3.4) of the the BMLT Meeting List Generator meeting information would never break between columns. If the entire table of information for a meeting would not fit the space available in the bottom of a column, it was moved to the next column under a new header for the same day but with (CONT) added. In bread 1.9.0 it is putting the name of the meeting at the bottom of the column then the rest of the information appears at the top of the next column with no meeting name or day header.

This is how it looks in bread 1.9.0:
bread-v1 9 0-meeting_list

This is how it works in BMLT Meeting List Generator 1.3.4:
bmlt_meeting_list_generator-v1 3 4-meeting_list

For now, have to roll back to the BMLT Meeting List Generator 1.3.4 for proper layout.

This is the source, currently with BMLT MLG 1.3.4 activated:
http://psana.eparna.org/?current-meeting-list=1

@californiasteve
Copy link

I'm having the same issue and have just been playing with font sizes and line heights to fix it. Your right that it hadn't done it before.

@dgershman
Copy link
Collaborator

Working on this

@dgershman
Copy link
Collaborator

Btw, I would not recommend rolling back to that plugin, it has severe vulnerabilities and you risk your entire server. You can roll back to prior bread 1.8.0 here
https://downloads.wordpress.org/plugin/bread.1.8.0.zip

@dgershman dgershman self-assigned this Jan 21, 2019
@dgershman dgershman added the bug label Jan 21, 2019
@dgershman
Copy link
Collaborator

Looks like 1.8.0 had this bug too.

@dgershman
Copy link
Collaborator

1.7.7 was the last known good version where this worked.

@dgershman
Copy link
Collaborator

@erleichdaarchiving
Copy link
Author

Thank you!

@dgershman
Copy link
Collaborator

I have a beta version ready to test if you are willing / able to:
https://github.com/bmlt-enabled/bread/archive/1.9.1-beta2.zip

@californiasteve
Copy link

Looks good to me. Tried it with three different service bodies and configurations. No problems.

@dgershman
Copy link
Collaborator

released in 1.9.4

@erleichdaarchiving
Copy link
Author

1.9.4 Is working great! Thank you.

@dgershman dgershman assigned dgershman and unassigned dgershman Aug 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants