Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add some test coverage #1

Merged
merged 1 commit into from Nov 20, 2013

Conversation

Projects
None yet
2 participants
@andyatkinson
Copy link
Contributor

commented Nov 19, 2013

  • a unit test for the HTTP headers to send
  • an integration test that hits the live page
    and adds a real YellowPage example from the
    documentation, with updates to the CSS selectors
    based on markup changes since the docs were written.

Instead of a live page, mocha could be used to
serve a stub HTML response, but that wasn't done
here.

After bundling, run "rake test" to run the tests.

Add some test coverage
 * a unit test for the HTTP headers to send

 * an integration test that hits the live page
and adds a real YellowPage example from the
documentation, with updates to the CSS selectors
based on markup changes since the docs were written.

Instead of a live page, mocha could be used to 
serve a stub HTML response, but that wasn't done
here.

After bundling, run "rake test" to run the tests.

bmuller added a commit that referenced this pull request Nov 20, 2013

@bmuller bmuller merged commit 9876a73 into bmuller:master Nov 20, 2013

@bmuller

This comment has been minimized.

Copy link
Owner

commented Nov 20, 2013

Awesome - thanks webandy!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.