Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dockerDistTar does not properly derive from (baseImage) configuration, when configuring both docker and dockerDistTar #12

Closed
vasanth-asokan opened this issue Dec 10, 2014 · 1 comment
Assignees
Labels
Milestone

Comments

@vasanth-asokan
Copy link

If I don't use a dockerDistTar configuration, the from is derived from the baseImage configuration of the docker task. But if I have to use dockerDistTar (say, to add files to dockerfile), the plugin seems to require a configuration for from in the dockerDistTar task in addition to the baseImage configuration in the docker closure.

dockerDistTar { 
    from 'dockerfile/java:openjdk-7-jdk'
    addFile 'foo', 'bar'
    addFile 'baz', 'foo'
}

docker { 
    javaApplication { 
        baseImage = 'dockerfile/java:openjdk-7-jdk'
    }
}

credentials { 
    username = 'johndoe'
    password = 'pwd'
    email = 'john@doe.com'
}

}

@bmuschko bmuschko added the bug label Dec 11, 2014
@bmuschko bmuschko self-assigned this Dec 11, 2014
bmuschko added a commit that referenced this issue Dec 14, 2014
… task with predefined instructions without messing up the order.
@bmuschko
Copy link
Owner

Thanks for reporting. This now works correctly. See integration test for more information.

@bmuschko bmuschko added this to the v0.7 milestone Dec 14, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants