New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Provider API instead of convention mapping #561

Closed
bmuschko opened this Issue Mar 18, 2018 · 2 comments

Comments

Projects
None yet
3 participants
@bmuschko
Copy link
Owner

bmuschko commented Mar 18, 2018

Expected Behavior

The code uses the Provider API instead of the internal API for convention mapping when configuring lazy-evaluated properties.

Current Behavior

The current code uses convention mapping which will go away sooner or later. As a user, I don't want to use an internal API to configure lazy values (meaning I need to know how it works but it is undocumented).

Example:

task pushImage(type: DockerPushImage) {
    dependsOn buildImage
    conventionMapping.imageName = { buildImage.getTag() }
}

Context

Avoid using an internal API. Usage of a public API.

@cdancy cdancy added the enhancement label Mar 18, 2018

@cdancy cdancy added this to the v3.2.6 milestone Mar 18, 2018

@cdancy

This comment has been minimized.

Copy link
Collaborator

cdancy commented Mar 18, 2018

Yeah never liked this and I push back on developers when I see them use this vs other more intuitive and well defined ways of doing the same thing.

@bmuschko

This comment has been minimized.

Copy link
Owner

bmuschko commented Jul 22, 2018

Assigned a major release to it as it will likely be a breaking change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment