Integrate GAE Plugin with Eclipse Plugin #9

Closed
wants to merge 4 commits into
from

Conversation

Projects
None yet
2 participants

ghost commented Dec 13, 2011

When using the Google plugin for Eclipse, it requires several files to be generated, and to have certain files be in locations it expects (i.e. JARs in WEB-INF/lib, output to WEB-INF/classes).

I've made modifications to the plugin to notice if both Eclipse and GAE plugins are enabled, to set up the project properly when 'gradle eclipse' is executed. Also, some modifications had to be made to integrate with the WAR plugin - to ignore the files that eclipse will be copying around.

@bmuschko

This comment has been minimized.

Show comment Hide comment
@bmuschko

bmuschko Dec 14, 2011

Owner

Hi John,

Thanks so much for your contribution. I really appreciate your work.

After reviewing your code I'd rather not put this code into the plugin because it adds to much specialness and details about the Eclipse Google plugin. I kind of can see a maintenance horror scenario when users try to use the plugin with different versions of the Eclipse plugin. Also your code depends on the explodedSdkDirectory variable which is only an option of the plugin. You could also run the plugin with the installed AppEngine SDK so this directory would not exist.

I'd recommend that you write a separate Gradle plugin that can run alongside with the GAE plugin just for setting up IDE projects for App Engine.

Ben

Owner

bmuschko commented Dec 14, 2011

Hi John,

Thanks so much for your contribution. I really appreciate your work.

After reviewing your code I'd rather not put this code into the plugin because it adds to much specialness and details about the Eclipse Google plugin. I kind of can see a maintenance horror scenario when users try to use the plugin with different versions of the Eclipse plugin. Also your code depends on the explodedSdkDirectory variable which is only an option of the plugin. You could also run the plugin with the installed AppEngine SDK so this directory would not exist.

I'd recommend that you write a separate Gradle plugin that can run alongside with the GAE plugin just for setting up IDE projects for App Engine.

Ben

This comment has been minimized.

Show comment Hide comment
@ghost

ghost Dec 14, 2011

Hi Ben-

Thanks for taking a look so quickly, I greatly appreciate the feedback. I completely agree with you that this code gets a little too specific to the GAE Eclipse Plugin. When it started out, I was thinking I would just be able to get away with simply adding some things to generate the .settings and .classpath files, but the Google plugin is quite specific....unfortunately.

I think I'll take your advice and start a new plugin that builds upon your plugin, as well as the eclipse and war plugins that gradle provides out of the box. However, when I'm done pushing this to its own plugin, would you mind adding a blurb to the FAQ section of your README file, to point users at it? I'm guessing I'm not the only one working with gradle and the Google Eclipse plugin for GAE development, and I'd like the community to take advantage (as well as possibly add valuable updates). It's likely going to be several weeks before I get around to this work, with the holidays coming up.

Thanks again for the quick feedback, and if there's anything you need help with.....please feel free to ask.

Happy Holidays
--John

ghost commented Dec 14, 2011

Hi Ben-

Thanks for taking a look so quickly, I greatly appreciate the feedback. I completely agree with you that this code gets a little too specific to the GAE Eclipse Plugin. When it started out, I was thinking I would just be able to get away with simply adding some things to generate the .settings and .classpath files, but the Google plugin is quite specific....unfortunately.

I think I'll take your advice and start a new plugin that builds upon your plugin, as well as the eclipse and war plugins that gradle provides out of the box. However, when I'm done pushing this to its own plugin, would you mind adding a blurb to the FAQ section of your README file, to point users at it? I'm guessing I'm not the only one working with gradle and the Google Eclipse plugin for GAE development, and I'd like the community to take advantage (as well as possibly add valuable updates). It's likely going to be several weeks before I get around to this work, with the holidays coming up.

Thanks again for the quick feedback, and if there's anything you need help with.....please feel free to ask.

Happy Holidays
--John

@ghost ghost closed this Dec 14, 2011

@bmuschko

This comment has been minimized.

Show comment Hide comment
@bmuschko

bmuschko Dec 15, 2011

Owner

I'd be happy to add a reference to your plugin in the FAQ section. Just shoot me a mail when you are done with it.

Happy Holidays,

Ben

Owner

bmuschko commented Dec 15, 2011

I'd be happy to add a reference to your plugin in the FAQ section. Just shoot me a mail when you are done with it.

Happy Holidays,

Ben

@ghost ghost assigned bmuschko Jan 24, 2012

This issue was closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment