New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

race.sh: change function definition syntax #5

Merged

bmwiedemann merged 1 commit into bmwiedemann:master from simson-sillage:fix-shebang

Aug 3, 2018

Contributor

simson-sillage commented Aug 2, 2018

Since not all distros use bash as default sh, and the script uses
function which is a bashism.

Owner

bmwiedemann commented Aug 3, 2018

Why not port it to standard shell and use racepart() instead. Tested it with Debian's dash


          race.sh: change function definition syntax

f6d54bb

`function` is a bashism and not all distros use bash as default sh.

simson-sillage force-pushed the fix-shebang branch from 15dd8b0 to f6d54bb Compare

August 3, 2018 19:59

simson-sillage changed the title ~~race.sh: change shebang to /bin/bash~~ race.sh: change function definition syntax

Contributor Author

simson-sillage commented Aug 3, 2018

I agree. Fixed

bmwiedemann merged commit 98d263a into bmwiedemann:master

Owner

bmwiedemann commented Aug 3, 2018

thanks a lot for this nice improvement

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment