fix: return error if 2/3 votes have not been achieved #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hallenger into fix/hash-verifier
This was referenced May 23, 2023
randyahx
added a commit
that referenced
this pull request
May 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Return an error if 2/3 votes have not been achieved
Skip event if Object was deleted on the blockchain
Rationale
Previously, no errors were returned so a MsgAttest was submitted for every event since they were set to EnoughVotesCollected
For some events, the objects may have been deleted by their original owner already so no verification is required
Example
none
Changes
Notable changes:
vote processor