Add new `hyper-mac-controls` to customization section #184

Merged
merged 4 commits into from Jan 12, 2017

Projects

None yet

3 participants

@krve
Contributor
krve commented Jan 11, 2017 edited

Make the hyperterm close, minimize and maximize buttons look like a mac.

Link to repo: hyper-mac-controls

Checklist for submitting an awesome plugin, theme, or resource:

  • The title for my package or theme uses its npm title (hyper-plugin-example)
  • The link for my package or theme uses the npmjs.com link (https://www.npmjs.com/package/hyper-plugin-example)
  • There is a visual representation of what my plugin or theme does in the repo. (Plugin: screenshot or gif || Theme: screenshot of the theme applied to Hyper)
  • Put your awesome item at the BOTTOM of the correct (plugin, theme, or resource) list.
  • VERY IMPORTANT: I've written a short (one sentence) description for my package or theme as the description of the awesome plugin, theme, or resource in the README.md file I'm submitting in the PR.
@darahak darahak self-requested a review Jan 11, 2017
@darahak
  • The name should match the URL and npm package.
  • "HyperTerm" is the old name. I believe now it should just be "Hyper".
@darahak
Collaborator
darahak commented Jan 11, 2017

Hello @krve, thanks a lot for the PR.
I just need you to make a few updates before I can merge it.

@krve
Contributor
krve commented Jan 11, 2017

@darahak I'll make the changes and change the name of the package as well.

@krve krve changed the title from Add new `hyperterm-mac-controls` to customization section to Add new `hyper-mac-controls` to customization section Jan 11, 2017
@krve
Contributor
krve commented Jan 11, 2017

I've updated the package name, as well as the link.

@iamstarkov

👍

@iamstarkov
Collaborator

@darahak want to take a look?

@darahak
Collaborator
darahak commented Jan 11, 2017

@krve Oh you went ahead and changed your package name.
I was just referencing the "HyperTerm" from the short description text, but that's really good.

Would you mind updating this part? (it's my last request I swear 😄 )

@krve
Contributor
krve commented Jan 12, 2017

@darahak haha, I just updated the description 😄

@darahak

Great! 👍

@darahak darahak merged commit 05de711 into bnb:master Jan 12, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment