Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix regression in Open Type Hierarchy #5255

Merged
merged 3 commits into from May 19, 2022
Merged

Conversation

bjhargrave
Copy link
Member

@bjhargrave bjhargrave commented May 18, 2022

The JDT type hierarchy search does not work properly when a
source folder is not-accessible following by a binary jar which is.
This caused types in the jar to be missing from the hierarchy result.

So we add back the source=project -buildpath clause option. The
value project is the default. So saying source=none on a -buildpath
entry, will cause Bndtools to mark the source project as discouraged
to force the compiler to use the classes in the generated jar.

Signed-off-by: BJ Hargrave <bj@hargrave.dev>
Also other fixes to clean up store implementation.

Signed-off-by: BJ Hargrave <bj@hargrave.dev>
@bjhargrave bjhargrave linked an issue May 18, 2022 that may be closed by this pull request
The JDT type hierarchy search does not work properly when a
source folder is not-accessible following by a binary jar which is.
This caused types in the jar to be missing from the hierarchy result.

So we add back the `source=project` -buildpath clause option. The
value `project` is the default. So saying `source=none` on a -buildpath
entry, will cause Bndtools to mark the source project as discouraged
to force the compiler to use the classes in the generated jar.

Fixes bndtools#5250

Signed-off-by: BJ Hargrave <bj@hargrave.dev>
@bjhargrave bjhargrave merged commit 4f2aa03 into bndtools:master May 19, 2022
10 checks passed
@bjhargrave bjhargrave deleted the fixes branch May 19, 2022 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Type hierarchy not displayed
1 participant