Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

signing: Write META-INF signing resources immediately after manifest #5268

Merged
merged 4 commits into from May 28, 2022

Conversation

bjhargrave
Copy link
Member

JarInputStream requires the META-INF signing resources to come
after the manifest and before any other resources. Otherwise,
JarInputStream does not consider the jar to be properly signed.

Later versions of Equinox now use JarInputStream to verify the
jar signing replacing Equinox's custom verification code. So Bnd
needs to properly generate signed jars to work with JarInputStream.

We also define a standard pattern for the META-INF signing resources
which is used by other classes that care.

Signed-off-by: BJ Hargrave <bj@hargrave.dev>
Signing is only possible when using the standard manifest name.

Signed-off-by: BJ Hargrave <bj@hargrave.dev>
Signed-off-by: BJ Hargrave <bj@hargrave.dev>
JarInputStream requires the META-INF signing resources to come
after the manifest and before any other resources. Otherwise,
JarInputStream does not consider the jar to be properly signed.

Later versions of Equinox now use JarInputStream to verify the
jar signing replacing Equinox's custom verification code. So Bnd
needs to properly generate signed jars to work with JarInputStream.

We also define a standard pattern for the META-INF signing resources
which is used by other classes that care.

Signed-off-by: BJ Hargrave <bj@hargrave.dev>
@bjhargrave bjhargrave merged commit 1e03d93 into bndtools:master May 28, 2022
10 checks passed
@bjhargrave bjhargrave deleted the jar-signing branch May 28, 2022 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant