resource: Defer SHA-256 calculation into the future #5323
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The osgi.content capability must hold the SHA-256 value of the resource. But this value is rarely used. So, when building a resource from a file, we defer the SHA-256 calculation until actually needed. The can help performance of FileSetRepository used by bndtools m2e. However, we do need the hashCode of the SHA-256 value early, so use a substitute hashCode value based upon the File object. This is not perfect since two files can hold identical content and the hashCode of their SHA-256 values should be identical. But in practice, this should work when creating a resource from a file since the early need for the hashCode of the SHA-256 value is in the computing of the hashCode of the capability so it can be inserted in a set. But creating a resource from a file only creates a single osgi.content capability. Fixes bndtools#5322 Signed-off-by: BJ Hargrave <bj@hargrave.dev>
When we know the input is a Set, we don't need to remove any duplicates. Signed-off-by: BJ Hargrave <bj@hargrave.dev>
Signed-off-by: BJ Hargrave <bj@hargrave.dev>
Signed-off-by: BJ Hargrave <bj@hargrave.dev>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
The osgi.content capability must hold the SHA-256 value of the
resource. But this value is rarely used. So, when building a resource
from a file, we defer the SHA-256 calculation until actually needed.
The can help performance of FileSetRepository used by bndtools m2e.
However, we do need the hashCode of the SHA-256 value early, so use
a substitute hashCode value based upon the File object. This is not
perfect since two files can hold identical content and the hashCode of
their SHA-256 values should be identical. But in practice, this should
work when creating a resource from a file since the early need for the
hashCode of the SHA-256 value is in the computing of the hashCode of
the capability so it can be inserted in a set. But creating a resource
from a file only creates a single osgi.content capability.
Fixes #5322