[cached resolve] The test failed on Windows #5339
Merged
+39
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I think this was caused by faster window machines. The reason for the operation was USE_CACHE which can only happen if the bndrun file did not pick up the time of the included file. I've added a 100 ms delay before taking a time, this 100 ms should be more than the resolution of the file system. So setting the time on the included file was not seen as later than the project file. I also added checks to see what the cache reason is before we call getRunBundles(). Lets see what happens Signed-off-by: Peter Kriens <Peter.Kriens@aqute.biz>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think this was caused by faster window machines.
The reason for the operation was USE_CACHE which
can only happen if the bndrun file did not pick up
the time of the included file.
I've added a 100 ms delay before taking a time,
this 100 ms should be more than the resolution of
the file system.
So setting the time on the included file was not
seen as later than the project file.
I also added checks to see what the cache reason is
before we call getRunBundles().
Lets see what happens
Signed-off-by: Peter Kriens Peter.Kriens@aqute.biz