Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

workspace: Fixes to workspace lock write-upgrade detection #5371

Merged

Conversation

bjhargrave
Copy link
Member

We use a queue since there will be more mutations than traversals. We only mark thread as holding read lock once it actually does. We only check for write upgrade when tryLock times out so we can potentially avoid traversing the queue.

Tests are also added.

We use a queue since there will be more mutations than traversals.
We only mark thread as holding read lock once it actually does. We
only check for write upgrade when tryLock times out so we can
potentially avoid traversing the queue.

Tests are also added.

Signed-off-by: BJ Hargrave <bj@hargrave.dev>
@bjhargrave bjhargrave merged commit e1eefb7 into bndtools:master Sep 19, 2022
11 checks passed
@bjhargrave bjhargrave deleted the workspace-lock-deadlock-detection-fix branch September 19, 2022 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant