Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

maven: Document access to Maven properties in Bnd instructions #5379

Merged
merged 1 commit into from Sep 26, 2022

Conversation

bjhargrave
Copy link
Member

Fixes #5375

Fixes bndtools#5375

Signed-off-by: BJ Hargrave <bj@hargrave.dev>
@bjhargrave bjhargrave merged commit 92599f4 into bndtools:master Sep 26, 2022
9 checks passed
@bjhargrave bjhargrave deleted the issues/5375 branch September 26, 2022 16:02
<groupId>biz.aQute.bnd</groupId>
<artifactId>bnd-maven-plugin</artifactId>
<configuration>
<bnd><![CDATA[
Copy link
Contributor

@kwin kwin Sep 26, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bjhargrave maybe this is not the best example, as with inline bnd instructions the replacement is actually done by Maven (https://maven.apache.org/ref/3.8.6/maven-model-builder/#model-interpolation). Only for external bnd files it is done by the bnd-maven-plugin IIUC.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps you can make a PR to improve the example?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Either split up the example to show both pom.xml and bnd.bnd or get rid of it alltogether I would say. But referencing https://maven.apache.org/ref/current/maven-model-builder/#model-interpolation in this context would be beneficial, as it works similarly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bnd-maven-plugin: Clarify property handling
2 participants