Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maven codegen #5385

Merged
merged 3 commits into from Oct 7, 2022
Merged

Maven codegen #5385

merged 3 commits into from Oct 7, 2022

Conversation

bjhargrave
Copy link
Member

This replaces #5319 since @juergen-albert never allows edits by maintainers.

image

I tidied things up, removed some files that should not have been in source control and restored some fixes that were reverted.

Signed-off-by: Juergen Albert <j.albert@data-in-motion.biz>
Signed-off-by: BJ Hargrave <bj@hargrave.dev>
Signed-off-by: Juergen Albert <j.albert@data-in-motion.biz>
Signed-off-by: BJ Hargrave <bj@hargrave.dev>
Signed-off-by: Juergen Albert <j.albert@data-in-motion.biz>
Signed-off-by: BJ Hargrave <bj@hargrave.dev>
@bjhargrave bjhargrave requested a review from juergen-albert Sep 29, 2022
@bjhargrave bjhargrave mentioned this pull request Sep 29, 2022
Copy link
Contributor

@juergen-albert juergen-albert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Sorry for not making my PR editable from the start. I definitelly need to make this my default. Right now I simply overlooked the checkbox.

@bjhargrave bjhargrave merged commit f383580 into bndtools:master Oct 7, 2022
19 of 20 checks passed
@bjhargrave bjhargrave deleted the maven_codegen branch Oct 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants