Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#5336 Need -include loop detection #5391

Merged
merged 5 commits into from Oct 7, 2022
Merged

#5336 Need -include loop detection #5391

merged 5 commits into from Oct 7, 2022

Conversation

pkriens
Copy link
Member

@pkriens pkriens commented Oct 6, 2022

The problem was that there was no test cases. There
actually was a loop detection. I already was incredibly
surprised because I am pretty sure I wrote this code
and forgetting to check cycles is even beneath me.However,
I'd forgotten to add a return after the error message ...

So the code continued forever to include the same
file anyway although dutifully reporting it.

Fixes #5336

Signed-off-by: Peter Kriens Peter.Kriens@aqute.biz

The problem was that there was no test cases. There
actually was a loop detection. I already was incredibly
surprised because I am pretty sure I wrote this code
and forgetting to check cycles is even beneath me.However,
I'd forgotten to add a return after the error message ...

So the code continued forever to include the same
file anyway although dutifully reporting it.

Fixes #5336

Signed-off-by: Peter Kriens <Peter.Kriens@aqute.biz>
---
 Signed-off-by: Peter Kriens <Peter.Kriens@aqute.biz>

Signed-off-by: Peter Kriens <Peter.Kriens@aqute.biz>
---
 Signed-off-by: Peter Kriens <Peter.Kriens@aqute.biz>

Signed-off-by: Peter Kriens <Peter.Kriens@aqute.biz>
Signed-off-by: Peter Kriens <Peter.Kriens@aqute.biz>
worked fine

Signed-off-by: Peter Kriens <Peter.Kriens@aqute.biz>
@pkriens
Copy link
Member Author

pkriens commented Oct 7, 2022

Slight apology for blamed windows for my own stupidity. Pushed to my fork instead of origin while trying to be a nice git citizen. No good deed goes unpunished :-(

@pkriens pkriens merged commit 1a3ae8b into master Oct 7, 2022
20 checks passed
@pkriens pkriens deleted the issue/5336 branch October 7, 2022 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bndtools] Need -include loop detection
1 participant