Renamed Bundle classes to be named like the bundle itself for more cl…

…arity
bnmrrs · Jun 23, 2010 · c486e1b · c486e1b
1 parent 4a74213
commit c486e1b
Show file tree

Hide file tree

Showing 12 changed files with 27 additions and 25 deletions.
diff --git a/...mfony/Framework/DoctrineBundle/Bundle.php → ...amework/DoctrineBundle/DoctrineBundle.php b/...mfony/Framework/DoctrineBundle/Bundle.php → ...amework/DoctrineBundle/DoctrineBundle.php
@@ -2,7 +2,7 @@
 
 namespace Symfony\Framework\DoctrineBundle;
 
-use Symfony\Foundation\Bundle\Bundle as BaseBundle;
+use Symfony\Foundation\Bundle\Bundle;
 use Symfony\Components\DependencyInjection\ContainerInterface;
 use Symfony\Components\DependencyInjection\Loader\Loader;
 use Symfony\Components\DependencyInjection\Loader\XmlFileLoader;
@@ -25,7 +25,7 @@
  * @author     Fabien Potencier <fabien.potencier@symfony-project.com>
  * @author     Jonathan H. Wage <jonwage@gmail.com>
  */
-class Bundle extends BaseBundle
+class DoctrineBundle extends Bundle
 {
     /**
      * Customizes the Container instance.

diff --git a/...ework/DoctrineMigrationsBundle/Bundle.php → ...ationsBundle/DoctrineMigrationsBundle.php b/...ework/DoctrineMigrationsBundle/Bundle.php → ...ationsBundle/DoctrineMigrationsBundle.php
@@ -2,7 +2,7 @@
 
 namespace Symfony\Framework\DoctrineMigrationsBundle;
 
-use Symfony\Foundation\Bundle\Bundle as BaseBundle;
+use Symfony\Foundation\Bundle\Bundle;
 
 /*
  * This file is part of the Symfony framework.
@@ -21,6 +21,6 @@
  * @author     Fabien Potencier <fabien.potencier@symfony-project.com>
  * @author     Jonathan H. Wage <jonwage@gmail.com>
  */
-class Bundle extends BaseBundle
+class DoctrineMigrationsBundle extends Bundle
 {
 }
diff --git a/...Symfony/Framework/PropelBundle/Bundle.php → ...y/Framework/PropelBundle/PropelBundle.php b/...Symfony/Framework/PropelBundle/Bundle.php → ...y/Framework/PropelBundle/PropelBundle.php
@@ -2,13 +2,13 @@
 
 namespace Symfony\Framework\PropelBundle;
 
-use Symfony\Foundation\Bundle\Bundle as BaseBundle;
+use Symfony\Foundation\Bundle\Bundle;
 use Symfony\Components\DependencyInjection\ContainerInterface;
 use Symfony\Components\DependencyInjection\Loader\Loader;
 use Symfony\Components\DependencyInjection\Loader\XmlFileLoader;
 use Symfony\Framework\PropelBundle\DependencyInjection\PropelExtension;
 
-class Bundle extends BaseBundle
+class PropelBundle extends Bundle
 {
     public function buildContainer(ContainerInterface $container)
     {

diff --git a/...ny/Framework/SwiftmailerBundle/Bundle.php → ...k/SwiftmailerBundle/SwiftmailerBundle.php b/...ny/Framework/SwiftmailerBundle/Bundle.php → ...k/SwiftmailerBundle/SwiftmailerBundle.php
@@ -2,7 +2,7 @@
 
 namespace Symfony\Framework\SwiftmailerBundle;
 
-use Symfony\Foundation\Bundle\Bundle as BaseBundle;
+use Symfony\Foundation\Bundle\Bundle;
 use Symfony\Components\DependencyInjection\ContainerInterface;
 use Symfony\Components\DependencyInjection\Loader\Loader;
 use Symfony\Framework\SwiftmailerBundle\DependencyInjection\SwiftmailerExtension;
@@ -23,7 +23,7 @@
  * @subpackage Framework_SwiftmailerBundle
  * @author     Fabien Potencier <fabien.potencier@symfony-project.com>
  */
-class Bundle extends BaseBundle
+class SwiftmailerBundle extends Bundle
 {
     /**
      * Customizes the Container instance.

diff --git a/src/Symfony/Framework/TwigBundle/Bundle.php → ...mfony/Framework/TwigBundle/TwigBundle.php b/src/Symfony/Framework/TwigBundle/Bundle.php → ...mfony/Framework/TwigBundle/TwigBundle.php
@@ -2,7 +2,7 @@
 
 namespace Symfony\Framework\TwigBundle;
 
-use Symfony\Foundation\Bundle\Bundle as BaseBundle;
+use Symfony\Foundation\Bundle\Bundle;
 use Symfony\Components\DependencyInjection\ContainerInterface;
 use Symfony\Components\DependencyInjection\Loader\Loader;
 use Symfony\Components\DependencyInjection\Loader\XmlFileLoader;
@@ -25,7 +25,7 @@
  * @subpackage Framework_TwigBundle
  * @author     Fabien Potencier <fabien.potencier@symfony-project.com>
  */
-class Bundle extends BaseBundle
+class TwigBundle extends Bundle
 {
     /**
      * Customizes the Container instance.

diff --git a/src/Symfony/Framework/WebBundle/Command/InitBundleCommand.php b/src/Symfony/Framework/WebBundle/Command/InitBundleCommand.php
@@ -77,5 +77,7 @@ protected function execute(InputInterface $input, OutputInterface $output)
             'namespace' => $namespace,
             'bundle'    => $bundle,
         ));
+
+        rename($targetDir.'/Bundle.php', $targetDir.'/'.$bundle.'.php');
     }
 }
diff --git a/src/Symfony/Framework/WebBundle/Controller/ControllerManager.php b/src/Symfony/Framework/WebBundle/Controller/ControllerManager.php
@@ -112,7 +112,7 @@ public function findController($controller)
                     $logs[] = sprintf('Failed finding controller "%s:%s" from namespace "%s" (%s)', $bundle, $controller, $namespace, $try);
                 }
             } else {
-                if (!in_array($namespace.'\\'.$bundle.'\\Bundle', array_map(function ($bundle) { return get_class($bundle); }, $this->container->getKernelService()->getBundles()))) {
+                if (!in_array($namespace.'\\'.$bundle.'\\'.$bundle, array_map(function ($bundle) { return get_class($bundle); }, $this->container->getKernelService()->getBundles()))) {
                     throw new \LogicException(sprintf('To use the "%s" controller, you first need to enable the Bundle "%s" in your Kernel class.', $try, $namespace.'\\'.$bundle));
                 }
 

diff --git a/src/Symfony/Framework/WebBundle/Resources/skeleton/application/xml/Kernel.php b/src/Symfony/Framework/WebBundle/Resources/skeleton/application/xml/Kernel.php
@@ -17,12 +17,12 @@ public function registerBundles()
     {
         $bundles = array(
             new Symfony\Foundation\Bundle\KernelBundle(),
-            new Symfony\Framework\WebBundle\Bundle(),
+            new Symfony\Framework\WebBundle\WebBundle(),
 
             // enable third-party bundles
-            new Symfony\Framework\ZendBundle\Bundle(),
-            new Symfony\Framework\DoctrineBundle\Bundle(),
-            new Symfony\Framework\SwiftmailerBundle\Bundle(),
+            new Symfony\Framework\ZendBundle\ZendBundle(),
+            new Symfony\Framework\DoctrineBundle\DoctrineBundle(),
+            new Symfony\Framework\SwiftmailerBundle\SwiftmailerBundle(),
 
             // register your bundles here
         );

diff --git a/src/Symfony/Framework/WebBundle/Resources/skeleton/application/yaml/Kernel.php b/src/Symfony/Framework/WebBundle/Resources/skeleton/application/yaml/Kernel.php
@@ -17,12 +17,12 @@ public function registerBundles()
     {
         $bundles = array(
             new Symfony\Foundation\Bundle\KernelBundle(),
-            new Symfony\Framework\WebBundle\Bundle(),
+            new Symfony\Framework\WebBundle\WebBundle(),
 
             // enable third-party bundles
-            new Symfony\Framework\ZendBundle\Bundle(),
-            new Symfony\Framework\DoctrineBundle\Bundle(),
-            new Symfony\Framework\SwiftmailerBundle\Bundle(),
+            new Symfony\Framework\ZendBundle\ZendBundle(),
+            new Symfony\Framework\DoctrineBundle\DoctrineBundle(),
+            new Symfony\Framework\SwiftmailerBundle\SwiftmailerBundle(),
 
             // register your bundles here
         );

diff --git a/src/Symfony/Framework/WebBundle/Resources/skeleton/bundle/Bundle.php b/src/Symfony/Framework/WebBundle/Resources/skeleton/bundle/Bundle.php
@@ -2,9 +2,9 @@
 
 namespace {{ namespace }}\{{ bundle }};
 
-use Symfony\Foundation\Bundle\Bundle as BaseBundle;
+use Symfony\Foundation\Bundle\Bundle;
 use Symfony\Components\DependencyInjection\ContainerInterface;
 
-class Bundle extends BaseBundle
+class {{ bundle }} extends Bundle
 {
 }
diff --git a/src/Symfony/Framework/WebBundle/Bundle.php → ...Symfony/Framework/WebBundle/WebBundle.php b/src/Symfony/Framework/WebBundle/Bundle.php → ...Symfony/Framework/WebBundle/WebBundle.php
@@ -2,7 +2,7 @@
 
 namespace Symfony\Framework\WebBundle;
 
-use Symfony\Foundation\Bundle\Bundle as BaseBundle;
+use Symfony\Foundation\Bundle\Bundle;
 use Symfony\Components\DependencyInjection\ContainerInterface;
 use Symfony\Components\DependencyInjection\Loader\Loader;
 use Symfony\Components\DependencyInjection\Loader\XmlFileLoader;
@@ -25,7 +25,7 @@
  * @subpackage Framework_WebBundle
  * @author     Fabien Potencier <fabien.potencier@symfony-project.com>
  */
-class Bundle extends BaseBundle
+class WebBundle extends Bundle
 {
     /**
      * Customizes the Container instance.

diff --git a/src/Symfony/Framework/ZendBundle/Bundle.php → ...mfony/Framework/ZendBundle/ZendBundle.php b/src/Symfony/Framework/ZendBundle/Bundle.php → ...mfony/Framework/ZendBundle/ZendBundle.php
@@ -2,7 +2,7 @@
 
 namespace Symfony\Framework\ZendBundle;
 
-use Symfony\Foundation\Bundle\Bundle as BaseBundle;
+use Symfony\Foundation\Bundle\Bundle;
 use Symfony\Components\DependencyInjection\ContainerInterface;
 use Symfony\Components\DependencyInjection\Reference;
 use Symfony\Components\DependencyInjection\Loader\Loader;
@@ -24,7 +24,7 @@
  * @subpackage Framework_ZendBundle
  * @author     Fabien Potencier <fabien.potencier@symfony-project.com>
  */
-class Bundle extends BaseBundle
+class ZendBundle extends Bundle
 {
     /**
      * Customizes the Container instance.