Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP
Browse files

Ignore pylint blacklist on Windows too

I'd been cursing pylint on every dcommit for the last year or
so and then doing --bypass-hooks. This seems an improvement.

R=thakis@chromium.org

Review URL: https://codereview.chromium.org/104683005

git-svn-id: http://gyp.googlecode.com/svn/trunk@1806 78cadc50-ecff-11dd-a971-7dbc132099af
  • Loading branch information...
commit 27c626e0515f845338cb60b1d8405f40150a791d 1 parent ce5fb1d
scottmg@chromium.org authored
Showing with 6 additions and 1 deletion.
  1. +6 −1 PRESUBMIT.py
View
7 PRESUBMIT.py
@@ -97,14 +97,19 @@ def CheckChangeOnCommit(input_api, output_api):
'http://gyp-status.appspot.com/status',
'http://gyp-status.appspot.com/current'))
+ import os
import sys
old_sys_path = sys.path
try:
sys.path = ['pylib', 'test/lib'] + sys.path
+ blacklist = PYLINT_BLACKLIST
+ if sys.platform == 'win32':
+ blacklist = [os.path.normpath(x).replace('\\', '\\\\')
+ for x in PYLINT_BLACKLIST]
report.extend(input_api.canned_checks.RunPylint(
input_api,
output_api,
- black_list=PYLINT_BLACKLIST,
+ black_list=blacklist,
disabled_warnings=PYLINT_DISABLED_WARNINGS))
finally:
sys.path = old_sys_path
Please sign in to comment.
Something went wrong with that request. Please try again.