Skip to content

Incorrect build for wscript #30

Closed
wants to merge 1 commit into from

3 participants

@schloerke

buffertools.js requires the buffertools.node file to be in the 'build/Require'. By default wscript puts the buffertools.node file into 'build/default'.

I tested npm install; node test.js for node.js versions 0.4.12 and 0.6.14. Each version had no output failure.

Idea taken from: brianmcd/contextify@92b63ba#wscript

Best,
Barret

@tifroz
tifroz commented Apr 12, 2012

+1!

@bnoordhuis
Owner

Thanks, merged in f479c13. I'll upload a new version to npm later this week (not on my regular computer right now).

@bnoordhuis bnoordhuis closed this Apr 13, 2012
@tifroz
tifroz commented Apr 16, 2012

@bnoordhuis could you could udpate npm? I'm afraid I'll eventually forget that my package.json pointed to tarball/master. Not the safest way ;)

@bnoordhuis
Owner

Right, thanks for reminding me. :-) 1.0.9 has been uploaded to npm just now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.