Skip to content
Commits on Apr 27, 2016
  1. lib: add Windows-31J alias for CP932

    Fixes #152.
    committed Apr 27, 2016
Commits on Apr 26, 2016
  1. package: upgrade to nan 2.2.1

    Unbreaks the build with node.js v6.  The minor bump is because the
    previous commit adds a new gyp variable.
    
    Fixes #153.
    committed Apr 27, 2016
  2. build: support linking against system libiconv

    `env GYP_DEFINES="node_iconv_use_system_libiconv=1" npm install` will
    now let you link against the system libiconv.
    
    Fixes #147.
    committed Mar 14, 2016
Commits on Dec 7, 2015
  1. @veselov

    lib: include charset names in error message

    Including charset names helps with debugging, avoiding to re-throw,
    or adding debugging statements arround.
    
    PR-URL: #140
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    veselov committed with Dec 4, 2015
Commits on Sep 26, 2015
  1. doc: update build instructions

    People need to run `npm install` first now to get the dependencies.
    committed Sep 26, 2015
Commits on Sep 25, 2015
  1. package: 2.1.10 -> 2.1.11

    committed Sep 25, 2015
  2. @gustavnikolaj
Commits on Aug 7, 2015
  1. package: upgrade to nan 2.0.4

    Fixes a build error with some Xcode versions, see
    nodejs/nan#404.
    
    Fixes #124.
    committed Aug 7, 2015
Commits on Aug 6, 2015
  1. package: upgrade to nan 2.0.2

    Makes node-iconv compatible with io.js v3.0.0.
    
    Fixes #123.
    committed Aug 6, 2015
Commits on Jun 6, 2015
  1. package: 2.1.7 -> 2.1.8

    committed Jun 6, 2015
  2. lib,test: turn on strict mode

    Up until now iconv.js and the test suite ran in sloppy mode for no good
    reason.  Change that.
    committed Jun 6, 2015
  3. test: add AIX and DOS encodings regression tests

    Ensure that the AIX and DOS encodings are available.
    
    Fixes #118.
    committed Jun 6, 2015
  4. @ashtuchkin

    build: get back DOS, AIX encodings

    Replace USE_EXTRA with ENABLE_EXTRA.  The latter implies the former but
    USE_AIX and USE_DOS as well.
    
    Fixes #118.
    ashtuchkin committed with May 23, 2015
Commits on May 5, 2015
  1. package: upgrade to nan 1.8.0

    Makes node-iconv compatible with io.js v2.0.0.
    
    Fixes #116.
    committed May 5, 2015
Commits on Feb 17, 2015
  1. package: upgrade to nan 1.6.2

    Makes node-iconv compatible with joyent/node v0.12.
    
    Fixes #108.
    committed Feb 17, 2015
Commits on Jan 20, 2015
  1. package: upgrade to nan 1.4.3

    Makes node-iconv compatible with io.js.
    
    Fixes #106.
    committed Jan 20, 2015
Commits on Dec 14, 2014
  1. @kkoopa

    src: upgrade to nan 1.2.0

    This effectively reverts commit 518052f; the build error has been fixed
    upstream.
    kkoopa committed with Jun 2, 2014
  2. build: disable msvc warnings for libiconv target

    Disable C4018, C4090, C4244 and C4267.  The libiconv target does not
    compile cleanly but it's code that we don't have direct control over.
    Fortunately, the warnings seem benign.
    committed Dec 14, 2014
  3. build: remove superfluous defines

    USE_EXTRA implies USE_AIX, USE_DOS and USE_OSF1; there is no need
    to define them explicitly.  Fixes macro redefinition warnings in
    deps/libiconv/lib/iconv.c.
    
    Remove LIBDIR, it's unused as of commit 03e7a1e.
    
    Refs #102.
    committed Dec 14, 2014
Commits on Jul 9, 2014
  1. src: macro locale_charset() takes no parameters

    Squelch msbuild warnings.  Refs #96.
    committed Jul 9, 2014
Commits on Jun 17, 2014
  1. deps: remove unused deps/libiconv/src/ directory

    Remove some more files that are not used by the library or the add-on.
    committed Jun 17, 2014
Commits on Jun 6, 2014
  1. doc: document encodings, add iconv-lite link

    * List supported encodings.
    
    * Link to iconv-lite for users that don't need the full range of
      encodings.
    
    * Remove Windows warning, it builds fine on Windows and has for years.
    committed Jun 6, 2014
Commits on May 28, 2014
  1. src: fix build error with nan 1.1.x

    Move the weak callback out of the class again.  Fixes the following
    build error:
    
        ../src/binding.cc:120:3: error: static and non-static member functions with the same parameter types cannot be overloaded
          NAN_WEAK_CALLBACK(WeakCallback)
          ^
        ../node_modules/nan/nan.h:1429:28: note: expanded from macro 'NAN_WEAK_CALLBACK'
            static NAN_INLINE void _Nan_Weak_Callback_ ## name(                        \
                                   ^
        <scratch space>:112:1: note: expanded from macro '_Nan_Weak_Callback_'
        _Nan_Weak_Callback_WeakCallback
        ^
        ../src/binding.cc:120:3: note: previous declaration is here
          NAN_WEAK_CALLBACK(WeakCallback)
          ^
        ../node_modules/nan/nan.h:1417:28: note: expanded from macro 'NAN_WEAK_CALLBACK'
            static NAN_INLINE void _Nan_Weak_Callback_ ## name(                        \
                                   ^
        <scratch space>:110:1: note: expanded from macro '_Nan_Weak_Callback_'
        _Nan_Weak_Callback_WeakCallback
    
    Affects at least gcc 4.2 and 4.8 on OS X and Linux.
    
    Fixes #92.
    committed May 28, 2014
Commits on May 24, 2014
  1. package: upgrade to nan 1.1.0

    Coincidentally fixes a small memory leak in the weak callback, see
    nodejs/nan#121 for details.
    committed May 24, 2014
  2. package: 2.1.1 -> 2.1.2

    Only notable change in this release is that the tarball is 13 MB
    smaller now.
    committed May 24, 2014
  3. deps: remove unused libiconv files

    Delete unused libiconv files, like configure scripts, m4 macros, tests,
    unused source files, etc.  Shrinks the download by about 13 MB.
    committed May 24, 2014
  4. src: provide locale_charset() stub

    Provide a stub function that lets us drop localcharset.c (and everything
    else from libcharset) from the list of compiled dependencies.
    
    Fixes #71.
    committed May 24, 2014
  5. src: upgrade to nan 1.0.0

    Makes node-iconv compile with the current node.js master again.
    
    Fixes #91.
    committed May 24, 2014
  6. build: build libiconv as standalone static library

    Build the bundled libiconv as a static library so compiler warning
    flags can be tweaked selectively.
    
    Before this commit the build was really noisy due to warnings in
    libiconv code.  Now warnings are enabled for the add-on (and have
    actually gotten more stringent) but are disabled for libiconv.
    committed May 24, 2014
  7. deps: make aliases2_lookup static, don't export it

    Fixes the following OS X dynamic linker issue with node.js master:
    
        $ $HOME/src/master/out/Release/node test/test-basic.js
        dyld: lazy symbol binding failed: Symbol not found: _aliases2_lookup
          Referenced from: /Users/bnoordhuis/src/node-iconv/build/Debug/iconv.node
          Expected in: dynamic lookup
    
        dyld: Symbol not found: _aliases2_lookup
          Referenced from: /Users/bnoordhuis/src/node-iconv/build/Debug/iconv.node
          Expected in: dynamic lookup
    
        Trace/BPT trap: 5
    
    The symbol is defined in deps/libiconv/lib/iconv.c (it's a function)
    but for some reason the symbol is marked as undefined in the shared
    object:
    
        $ nm build/Debug/iconv.node | grep aliases2
                         U _aliases2_lookup
    
    Note that it's undefined both with v0.10 and master so it's anybody's
    guess why master triggers the lookup error but v0.10 doesn't.  At any
    rate, it's easy to work around by making the function static.
    committed May 24, 2014
Commits on Apr 26, 2014
  1. package: add tap dependency and `npm test` target

    Follow the semi-standard practice of having a `npm test` target that
    - surprise, surprise! - runs the test suite.  Should make the project
    a little more approachable to outside contributors.
    committed Apr 26, 2014
  2. package: 2.0.7 -> 2.1.0

    The minor bump is because of commit 053dfee ("lib: add convert/write/end
    encoding argument") which is arguably an API change, albeit a minor one.
    committed Apr 26, 2014
  3. @fengmk2

    package: update nan to 0.8.0, support node@0.11.9+

    (Editor's note: but not node.js master, that will have to wait until
    nan 0.9.0 is released.)
    
    Fixes #88.
    fengmk2 committed with Apr 14, 2014
Commits on Jan 19, 2014
  1. @rvagg
Something went wrong with that request. Please try again.