Skip to content

profiler didn't install with spaces in the path to node_modules #4

Closed
wants to merge 4 commits into from

2 participants

@wmertens

No description provided.

wmertens added some commits Aug 17, 2012
@wmertens wmertens Make resistant to spaces in paths 9ff8951
@wmertens wmertens Install nprof as a CLI tool 61651ef
@wmertens wmertens Correct build paths on npm install ace45d1
@wmertens wmertens Make NPM install work
Since node-gyp is extremely fickle and not installed by default, this uses
node-waf. To allow windows to use nprof it also includes the nprof
prebuilt.
2430b41
@bnoordhuis
Owner

Can you rebase your PR against master? Your PR contains changes that look like they're from old node-profiler revisions.

@wmertens

Actually, It's only one commit behind and doesn't touch any of that code.

You could cherry-pick 9ff8951 if you only want the spaces in path fix...

@bnoordhuis
Owner

Thanks, landed in 95c021e.

@bnoordhuis bnoordhuis closed this Sep 26, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.