Skip to content
Commits on Aug 7, 2014
  1. @tjfontaine
  2. @tjfontaine

    Merge remote-tracking branch 'upstream/v0.10' into v0.12

    tjfontaine committed Aug 7, 2014
  3. @misterdjules @tjfontaine

    tests: fix child-process-fork-dgram on SmartOS.

    Send messages until both the parent and the child process have received
    at least one message. If at least one of them doesn't receive any
    message, the test runner will make the test timeout.
    Fixes #8046.
    misterdjules committed with tjfontaine Jul 31, 2014
  4. @tjfontaine
  5. @mmalecki @tjfontaine
  6. @JacksonTian @tjfontaine
  7. @saghul @indutny

    src: handle UV_EAGAIN in TryWrite

    Reviewed-By: Fedor Indutny <>
    saghul committed with indutny Jul 5, 2014
  8. @orangemocha @indutny

    Cluster: fix shared handles on Windows

    This is the Node side of the fix for Node's cluster module on Windows.
    The other required part is
    Windows and Unix return certain socket errors (i.e. EADDRINUSE) at
    different times: bind on Windows, and listen on Unix.
    In an effort to hide this difference, libuv on Windows stores such
    errors in the bind_error field of uv_tcp_t, to defer raising it at
    listen time.
    This worked fine except for the case in which a socket is shared in
    a Node cluster and a bind error occurs.
    A previous attempt to fix this (
    ) was flawed becaused in an attempt to relay the error at the JS level
    it caused the master to start accepting connections.
    With this new approach, libuv itself is relaying the bind errors,
    providing for a uniform behavior of uv_tcp_listen.
    Reviewed-By: Fedor Indutny <>
    orangemocha committed with indutny Jul 24, 2014
  9. @indutny

    deps: update libuv to v0.11.28

    indutny committed Aug 7, 2014
  10. @indutny
Commits on Aug 6, 2014
  1. @kevinsimper @tjfontaine
Commits on Aug 5, 2014
  1. @JacksonTian @indutny

    fs: fs.readFile should not throw uncaughtException

    Reviewed-By: Fedor Indutny <>
    JacksonTian committed with indutny Aug 5, 2014
  2. @trevnorris

    dns: fix GetAddrInfo assert

    The method GetAddrInfo() is used by more than just dns.lookup(), and in
    those cases a third argument isn't passed. This caused the following
    check to abort:
    Fixes: 4306786 "net: don't prefer IPv4 addresses during resolution"
    Signed-off-by: Trevor Norris <>
    trevnorris committed Aug 4, 2014
Commits on Aug 4, 2014
  1. @cjihrig @trevnorris

    net: don't prefer IPv4 addresses during resolution

    Currently the address resolution family defaults to IPv4. Instead remove
    the preference and instead resolve to a family suitable for the host.
    Expose the getaddrinfo flags and allow them to be passed.
    Add documentation about new flags.
    Reviewed-by: Trevor Norris <>
    cjihrig committed with trevnorris May 21, 2014
  2. @tjfontaine

    v8: Fix compliation with GCC 4.8

    Supresses a very loud warning from GCC 4.8 about unused typedefs
    Original url
    tjfontaine committed Aug 4, 2014
  3. @misterdjules @trevnorris

    test: fix test-net-remote-address-port

    Do not use first socket in second socket's connect handler. Probably a
    copy/paste mistake.
    Reviewed-by: Trevor Norris <>
    misterdjules committed with trevnorris Aug 1, 2014
  4. @threeday0905 @trevnorris

    path: isAbsolute() should always return boolean

    On Windows, path.isAbsolute() returns an empty string on failed cases.
    This forces the return value to always be boolean.
    Reviewed-by: Trevor Norris <>
    threeday0905 committed with trevnorris Aug 4, 2014
  5. @misterdjules @tjfontaine

    timers: fix timers with non-integer delay hanging.

    When backporting f8193ab into v0.10, a regression was introduced. Timers
    with non-integer timeout could trigger a infinite recursion with 100%
    cpu usage. This commit backports 93b0624 which fixes the regression.
    After backporting f8193ab, instead of using, timers would use to determine if they had expired. However, is
    based on loop->time, which is not updated when a timer's remaining time
    is > 0 and < 1. Timers would thus never timeout if their remaining time
    was at some point > 0 and < 1.
    With this commit, updates loop->time itself, and timers
    always timeout eventually.
    Fixes #8065 and #8068.
    misterdjules committed with tjfontaine Aug 4, 2014
Commits on Aug 2, 2014
  1. @JacksonTian @indutny

    process: improve process binding

    Reviewed-By: Fedor Indutny <>
    JacksonTian committed with indutny Aug 1, 2014
  2. @indutny

    test: disable 0-dgram tests on darwin

    fix #8023
    indutny committed Aug 2, 2014
  3. @sam-github @trevnorris

    cluster: disconnect should not be synchronous

    Callbacks in node are usually asynchronous, and should never be
    sometimes synchronous, and sometimes asynchronous.
    Reviewed-by: Trevor Norris <>
    sam-github committed with trevnorris Jul 31, 2014
  4. @luciotato @trevnorris

    path: fix slice OOB in trim

    Internal function trim(arr). 2nd parameter of slice() should be slice's
    end index (not included). Because of function normalize() (called before
    trim()), "start" is always zero so the bug -for now- has no effect, but
    its a bug waiting to happen.
    Reviewed-by: Trevor Norris <>
    luciotato committed with trevnorris Aug 2, 2014
  5. @sam-github @trevnorris

    test: assert cluster.disconnect is async

    See nodejs/node-v0.x-archive#8043, test passed on v0.11 already, but this makes the
    test stronger.
    Reviewed-by: Trevor Norris <>
    sam-github committed with trevnorris Jul 31, 2014
Commits on Aug 1, 2014
  1. @substack @trevnorris

    stream: fix Readable.wrap objectMode falsy values

    A streams1 stream will have its falsy values such as 0, false, or ""
    eaten by the upgrade to streams2, even when objectMode is enabled.
    Include test for said cases.
    Reviewed-by: isaacs <>
    Reviewed-by: Trevor Norris <>
    substack committed with trevnorris Jun 8, 2014
  2. @JacksonTian @indutny

    tls: throw an error, not string

    Reviewed-By: Fedor Indutny <>
    JacksonTian committed with indutny Aug 1, 2014
Commits on Jul 31, 2014
  1. @cjihrig @indutny

    cluster: support options in Worker constructor

    This commit moves some common Worker code into the constructor
    via support for an options argument.
    Reviewed-By: Fedor Indutny <>
    cjihrig committed with indutny Jul 30, 2014
  2. @jgillich @indutny

    docs: fix non-string ignore note in path.resolve

    Reviewed-By: Fedor Indutny <>
    jgillich committed with indutny Jun 25, 2014
  3. @gwicke @indutny

    Add fast path for simple URL parsing

    This patch adds a fast path for parsing of simple path-only URLs, as commonly
    found in HTTP requests received by a server.
    Benchmark results [ms], before / after patch:
    /foo/bar              0.008956   0.000418 (fast path used)   0.011426   0.011437 (normal slow path, no change)
    In a simple 'ab' benchmark of a single-threaded web server, this patch
    increases the request rate from around 6400 to 7400 req/s.
    Reviewed-By: Fedor Indutny <>
    gwicke committed with indutny Jul 1, 2014
  4. @tjfontaine

    Now working on 0.10.31

    tjfontaine committed Jul 31, 2014
  5. @tjfontaine
  6. @tjfontaine

    2014.07.31, Version 0.10.30 (Stable)

    * uv: Upgrade to v0.10.28
    * npm: Upgrade to v1.4.21
    * v8: Interrupts must not mask stack overflow.
    * Revert "stream: start old-mode read in a next tick" (Fedor Indutny)
    * buffer: fix sign overflow in `readUIn32BE` (Fedor Indutny)
    * buffer: improve {read,write}{U}Int* methods (Nick Apperson)
    * child_process: handle writeUtf8String error (Fedor Indutny)
    * deps: backport 4ed5fde4f from v8 upstream (Fedor Indutny)
    * deps: cherry-pick eca441b2 from OpenSSL (Fedor Indutny)
    * lib: remove and restructure calls to isNaN() (cjihrig)
    * module: eliminate double `getenv()` (Maciej Małecki)
    * stream2: flush extant data on read of ended stream (Chris Dickinson)
    * streams: remove unused require('assert') (Rod Vagg)
    * timers: backport f8193ab (Julien Gilli)
    * util.h: interface compatibility (Oguz Bastemur)
    * zlib: do not crash on write after close (Fedor Indutny)
    tjfontaine committed Jul 31, 2014
  7. @tjfontaine

    uv: Upgrade to v0.10.28

    tjfontaine committed Jul 31, 2014
  8. @indutny @tjfontaine
  9. @tjfontaine

    npm: Upgrade to v1.4.21

    tjfontaine committed Jul 31, 2014
  10. @mmalecki @tjfontaine

    module: eliminate double `getenv()`

    `process.env` access results in a synchronous `getenv` call. Cache the
    first result instead and save one syscall.
    mmalecki committed with tjfontaine Mar 26, 2014
Something went wrong with that request. Please try again.