feat(examples): Add comprehensive JsPromise example - #4198
Merged
jedel1043 merged 3 commits intoMar 13, 2025
Conversation
This commit adds a new example demonstrating various features of JsPromise: - Basic promise creation and handling - Promise chaining with then/catch/finally - Promise.all example with multiple promises - Promise.race example with timing - Converting Rust Future to Promise using from_future - Promise.any example with mixed resolve/reject The example uses tokio for async functionality and demonstrates proper error handling and promise state management.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4198 +/- ##
==========================================
+ Coverage 47.24% 52.68% +5.44%
==========================================
Files 476 488 +12
Lines 46892 52005 +5113
==========================================
+ Hits 22154 27401 +5247
+ Misses 24738 24604 -134 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
Author
|
Hi @jedel1043 Let me know if there's anything I need to add/change in the examples. |
nekevss
added
C-Documentation
Contributor
Author
|
Hi team |
jedel1043
approved these changes
Mar 13, 2025
jedel1043
left a comment
jedel1043
left a comment
Member
There was a problem hiding this comment.
Thank you for the reminder! I think this looks good, and it extensively uses all the Promise APIs exposed, so thank you for the contribution!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This Pull Request fixes/closes #2761
It changes the following:
This commit adds a new example demonstrating various features of JsPromise:
The example uses tokio for async functionality and demonstrates proper error handling and promise state management.