Repository navigation
Implement Upsert methods for weakMap: getOrInsert and getOrInsertComputed - #4459
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4459 +/- ##
==========================================
+ Coverage 47.24% 51.55% +4.30%
==========================================
Files 476 504 +28
Lines 46892 51454 +4562
==========================================
+ Hits 22154 26525 +4371
- Misses 24738 24929 +191 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jedel1043
requested changes
Oct 8, 2025
jedel1043
left a comment
Member
There was a problem hiding this comment.
Everything looks nice! I just have a couple of suggestions to improve the code.
Test262 conformance changes
Fixed tests (15): |
jedel1043
approved these changes
Oct 14, 2025
jedel1043
left a comment
Member
There was a problem hiding this comment.
Very nice, it looks great!
You may need to rebase the PR though, but we can merge after that.
- Enforce object keys; callable callback; reentrancy-safe insert/update. - Register methods, update constructor metadata, and add tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This Pull Request closes #4435, implementing the Upsert proposal for weak map
It changes the following:
WeakMap.prototype.getOrInsertmethod.WeakMap.prototype.getOrInsertComputedmethod.