Make package.json scripts work on Windows#657
Merged
delucis merged 6 commits intoboardgameio:masterfrom May 2, 2020
c-w:windows
Merged
Make package.json scripts work on Windows#657delucis merged 6 commits intoboardgameio:masterfrom c-w:windows
delucis merged 6 commits intoboardgameio:masterfrom
c-w:windows
Conversation
Member
|
Thanks for taking the time to do this!! Will take a closer look in a few days (busy this week). |
ksjogo
previously approved these changes
Apr 30, 2020
ksjogo
reviewed
Apr 30, 2020
also rename install-web.js to install-examples.js
Member
|
@c-w Made a few changes. Let me know if they look good to you. The main addition is to run "build" in prestart so you can just do: when you first clone the repo. |
Contributor
Author
|
@nicolodavis Changes LGTM. |
delucis
approved these changes
May 2, 2020
Member
|
Thanks Clemens! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently there are several bashisms in the various package.json scripts which makes it impossible to work on boardgame.io natively on Windows without using a Linux emulation layer such as WSL. This commit replaces the bashisms with cross-platform Node commands.
Checklist
master).