Skip to content

Make package.json scripts work on Windows#657

Merged
delucis merged 6 commits intoboardgameio:masterfrom
c-w:windows
May 2, 2020
Merged

Make package.json scripts work on Windows#657
delucis merged 6 commits intoboardgameio:masterfrom
c-w:windows

Conversation

@c-w
Copy link
Copy Markdown
Contributor

@c-w c-w commented Apr 30, 2020

Currently there are several bashisms in the various package.json scripts which makes it impossible to work on boardgame.io natively on Windows without using a Linux emulation layer such as WSL. This commit replaces the bashisms with cross-platform Node commands.

Checklist

  • Use a separate branch in your local repo (not master).
  • Test coverage is 100% (or you have a story for why it's ok).

@nicolodavis
Copy link
Copy Markdown
Member

Thanks for taking the time to do this!! Will take a closer look in a few days (busy this week).

ksjogo
ksjogo previously approved these changes Apr 30, 2020
Comment thread package.json
@nicolodavis
Copy link
Copy Markdown
Member

@c-w Made a few changes. Let me know if they look good to you.

The main addition is to run "build" in prestart so you can just do:

npm install
npm start

when you first clone the repo.

@c-w
Copy link
Copy Markdown
Contributor Author

c-w commented May 2, 2020

@nicolodavis Changes LGTM.

@delucis delucis merged commit 814621b into boardgameio:master May 2, 2020
@delucis
Copy link
Copy Markdown
Member

delucis commented May 2, 2020

Thanks Clemens!

@c-w c-w deleted the windows branch May 2, 2020 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants