Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make package.json scripts work on Windows #657

Merged
merged 6 commits into from May 2, 2020
Merged

Make package.json scripts work on Windows #657

merged 6 commits into from May 2, 2020

Conversation

c-w
Copy link
Contributor

@c-w c-w commented Apr 30, 2020

Currently there are several bashisms in the various package.json scripts which makes it impossible to work on boardgame.io natively on Windows without using a Linux emulation layer such as WSL. This commit replaces the bashisms with cross-platform Node commands.

Checklist

  • Use a separate branch in your local repo (not master).
  • Test coverage is 100% (or you have a story for why it's ok).

@nicolodavis
Copy link
Member

nicolodavis commented Apr 30, 2020

Thanks for taking the time to do this!! Will take a closer look in a few days (busy this week).

ksjogo
ksjogo previously approved these changes Apr 30, 2020
package.json Show resolved Hide resolved
@nicolodavis
Copy link
Member

nicolodavis commented May 2, 2020

@c-w Made a few changes. Let me know if they look good to you.

The main addition is to run "build" in prestart so you can just do:

npm install
npm start

when you first clone the repo.

@c-w
Copy link
Contributor Author

c-w commented May 2, 2020

@nicolodavis Changes LGTM.

delucis
delucis approved these changes May 2, 2020
@delucis delucis merged commit 814621b into boardgameio:master May 2, 2020
2 checks passed
@delucis
Copy link
Member

delucis commented May 2, 2020

Thanks Clemens!

@c-w c-w deleted the windows branch May 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants