Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(server): Enable passing through SocketIO options #658

Merged
merged 5 commits into from May 2, 2020
Merged

feat(server): Enable passing through SocketIO options #658

merged 5 commits into from May 2, 2020

Conversation

c-w
Copy link
Contributor

@c-w c-w commented Apr 30, 2020

This pull request (1) exposes the SocketIO object in the server package so that clients can construct their own instantiation of the transport and pass it through to the Server constructor and (2) enables passing through configuration options to the underlying socket.io server.

These two changes combined enable running boardgame.io in hosting environments such as Azure App Service which require setting certain SocketIO configuration options to be set like perMessageDeflate (see Azure docs).

Checklist

  • Use a separate branch in your local repo (not master).
  • Test coverage is 100% (or you have a story for why it's ok).

src/server/index.ts Outdated Show resolved Hide resolved
@c-w c-w changed the title feat(server): Enable passing through SocketIO options feat(package): Expose SocketIO in server module Apr 30, 2020
@c-w c-w closed this Apr 30, 2020
@c-w c-w deleted the socketio branch Apr 30, 2020
@c-w c-w restored the socketio branch Apr 30, 2020
@c-w c-w reopened this Apr 30, 2020
@c-w c-w changed the title feat(package): Expose SocketIO in server module feat(server): Enable passing through SocketIO options Apr 30, 2020
delucis
delucis approved these changes May 2, 2020
@delucis delucis merged commit dc668ec into boardgameio:master May 2, 2020
2 checks passed
@c-w c-w deleted the socketio branch May 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants