feat(server): Enable passing through SocketIO options #658
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolodavis
reviewed
Apr 30, 2020
c-w
changed the title
c-w
changed the title
delucis
approved these changes
May 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request (1) exposes the SocketIO object in the server package so that clients can construct their own instantiation of the transport and pass it through to the Server constructor and (2) enables passing through configuration options to the underlying socket.io server.
These two changes combined enable running boardgame.io in hosting environments such as Azure App Service which require setting certain SocketIO configuration options to be set like
perMessageDeflate(see Azure docs).Checklist
master).