Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(lobby): Convert React components to Typescript #826

Merged
merged 6 commits into from Oct 13, 2020
Merged

refactor(lobby): Convert React components to Typescript #826

merged 6 commits into from Oct 13, 2020

Conversation

c-w
Copy link
Contributor

@c-w c-w commented Oct 13, 2020

Similar to @coyotte508 in #190 (comment), I recently ran into an issue importing boardgame.io/client due to the missing types in the Lobby React components. As such, this pull request converts the Lobby React components to Typescript which should fix the import error.

Checklist

  • Use a separate branch in your local repo (not master).
  • Test coverage is 100% (or you have a story for why it's ok).

Copy link
Member

@delucis delucis left a comment

Nice work! A couple of small questions, but otherwise this looks great.

src/lobby/react.tsx Outdated Show resolved Hide resolved
src/lobby/react.tsx Show resolved Hide resolved
@c-w c-w requested a review from delucis Oct 13, 2020
@delucis delucis merged commit 74f7a40 into boardgameio:master Oct 13, 2020
1 check passed
@delucis
Copy link
Member

delucis commented Oct 13, 2020

Thanks @c-w!

@c-w c-w deleted the c-w/typescript-lobby-component branch Oct 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants