Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Added a minimum version for cmake #22
cmake tool requires CMakeLists.txt to define a minimum version since its 2.6 version:
if you set cmake_minimum_required to the first supported version you will get following error:
So you need to merge two target_link_libraries.
All steps above are needed because if you try to import facil.io from other cmake project using add_subdirectory, and that project have set the required version you will get the same errors:
Thank you very much for this PR!!!
I don't use CMake, so I really don't encounter these issues.
However, I should point out that the CMakeLists.txt file is automatically generated by the project's makefile.
I will add these changes to the generator script, but I would appreciate if you could look it over and make sure it works as expected.