New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't call oik_batch_trace #26

Closed
bobbingwide opened this Issue Dec 21, 2017 · 1 comment

Comments

Projects
None yet
1 participant
@bobbingwide
Copy link
Owner

bobbingwide commented Dec 21, 2017

While developing PHPUnit tests for oik-bwtrace I found that having the BW_TRACE_ON constant set to true made it difficult to test some functions.

The pragmatic approach is to not call the oik_batch_trace function. Functions affected are oik_batch_loaded and oik-wp-loaded.

@bobbingwide bobbingwide self-assigned this Dec 21, 2017

bobbingwide added a commit that referenced this issue Dec 21, 2017

@bobbingwide

This comment has been minimized.

Copy link
Owner Author

bobbingwide commented Feb 4, 2019

I'm going to close this. The PHPUnit tests for oik-bwtrace, such as they were, did run to completion after the calls were commented out.

@bobbingwide bobbingwide closed this Feb 4, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment